Upgrade Qt to 5.6

[vitallium]

Qt 5.6 was released today http://blog.qt.io/blog/2016/03/16/qt-5-6-released/

Change log: https://wiki.qt.io/New_Features_in_Qt_5.6

This is a stub issue for referencing in future.

Check list:

• Linux
• OS X
• Windows

Cheers!

[Vanuan]

AFAIK Qt 5.6 removed QtWebkit support and migrated to chromium. Isn't that true?

[Vanuan]

With Qt 5.6 the following modules are no longer part of the release packages, but users can still build them from source:

• Qt WebKit

Qt WebEngine

• Based on Chromium 45

[vitallium]

@Vanuan that's not a problem. Updated WebKit is coming - https://github.com/annulen/webkit

[Vanuan]

Ah, so phantomjs would use WebKit directly?

[vitallium]

@Vanuan kind of. We will maintain our own QtWebkit.

[annulen]

@Vanuan In fact there is a community release of QtWebKit 5.6:
http://download.qt.io/community_releases/5.6/5.6.0/

[elachlan]

Am I correct in assuming this would fix the security issue that is blocking package acceptance in Debian?
https://security-tracker.debian.org/tracker/CVE-2013-4549

[annulen]

QXmlSimpleReader is not used in QtWebKit and PhantomJS, so I believe this CVE has no relation to PhantomJS

[elachlan]

Does anyone know the process to have it removed from the CVE?

[zackw]

@elachlan Until there's a maintained QtWebkit that is keeping up with Webkit security advisories and PhantomJS can use both that and unmodified system-provided Qt, packaging it for Debian - or any other distro - is inappropriate. I specifically told them a few months ago that they should drop the package altogether. Maybe I should try to prod that process along.

Until that time, also, it's probably unsafe to use PhantomJS on untrusted content, especially on Windows.

[vitallium]

Windows +

[vitallium]

Landed in master

[astefanutti]

@vitallium, I've just tried compiling @5d99f2a on Mac OS X (10.11.5) and Qt WebKit build fails with the following error message:

rm -f /Users/astefanu/Development/phantomjs-test/src/qt/qtbase/lib/libQt5WebKit.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ar cq /Users/astefanu/Development/phantomjs-test/src/qt/qtbase/lib/libQt5WebKit.a 
ar: no archive members specified
usage:  ar -d [-TLsv] archive file ...
    ar -m [-TLsv] archive file ...
    ar -m [-abiTLsv] position archive file ...
    ar -p [-TLsv] archive [file ...]
    ar -q [-cTLsv] archive file ...
    ar -r [-cuTLsv] archive file ...
    ar -r [-abciuTLsv] position archive file ...
    ar -t [-TLsv] archive [file ...]
    ar -x [-ouTLsv] archive [file ...]
make[2]: *** [/Users/astefanu/Development/phantomjs-test/src/qt/qtbase/lib/libQt5WebKit.a] Error 1
make[1]: *** [sub-api-pri-make_first-ordered] Error 2
make: *** [sub-Source-QtWebKit-pro-make_first-ordered] Error 2

ERROR: Failed to build PhantomJS! Building Qt WebKit failed.

I've opened vitallium/qtwebkit#11 that fixes the issue.

[sowani]

By any chance, https://github.com/annulen/webkit/releases/tag/qtwebkit-tp5 will be used in PhantomJS?

[vitallium]

@sowani by any chance - PhantomJS 2.5 already uses this fork ;-)

[phawxby]

@vitallium where is V2.5? I don't see it listed in releases?
https://github.com/ariya/phantomjs/releases

I'm suffering from issues with flexbox, blurring and broken webfonts (I believe this is Windows only) and I think this is due to the old Webkit version in V2.1

[annulen]

@phawxby See https://bitbucket.org/ariya/phantomjs/downloads/

[phawxby]

What on earth is it doing there?

[izzyonstage]

is there any tags to the source for the 2.5 build?
We have some custome PJS changes we make in-house and it would be good to be able to use a build that has tp5 in it.

[phawxby]

Medium/phantomjs#689

You can pull directly from my repo if you want although I would look at the pull conversation.
https://github.com/phawxby/phantomjs

[izzyonstage]

What I really need is the source code as I have some custom additions I need to add so the binaries are useless for me.

Also I am building for Windows platform as well as Linux