This repository has been archived by the owner on May 30, 2023. It is now read-only.
Correcting keycodes sent for lowercase characters #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Landed. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
WebPage::sendEventfor keystrokes sends the Unicode value of the character. For uppercase characters, this matches to the value of the character in theQt::Keyenum; for lowercase characters, it does not. Thus, items like sending Control-x for cut or Control-v for paste do not work, as the keycodes are not what are expected.The correct fix is to send the value of the uppercase character for the keycode, retaining the lowercase character in the "text" argument of the
QKeyEventconstructor so that the proper actual character gets sent.This pull request fixes issue #852 (http://code.google.com/p/phantomjs/issues/detail?id=852).