Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some additions for user.js that are worth. #1408

Closed
IkelAtomig opened this issue Mar 29, 2022 · 9 comments
Closed

Some additions for user.js that are worth. #1408

IkelAtomig opened this issue Mar 29, 2022 · 9 comments

Comments

@IkelAtomig
Copy link

security.secure_connection_icon_color_gray Changes the colour of the secure connection padlock icon in the address bar to white/black (depending on if your theme is light ordark), or green. Enabled by default.

Set to true for white/black, and false for green.

Set as Green in AF.

For Autoplay - media.autoplay.default = 5 [0:allow; 1:blockAudible; 5:blockAll]

@rusty-snake
Copy link
Contributor

For Autoplay - media.autoplay.default = 5 [0:allow; 1:blockAudible; 5:blockAll]

user.js/user.js

Lines 645 to 649 in b4225ba

/* 2030: disable autoplay of HTML5 media [FF63+]
* 0=Allow all, 1=Block non-muted media (default), 5=Block all
* [NOTE] You can set exceptions under site permissions
* [SETTING] Privacy & Security>Permissions>Autoplay>Settings>Default for all websites ***/
// user_pref("media.autoplay.default", 5);

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented Mar 29, 2022

I'd have to look up the reasoning for the removed color, but IIRC its part of a longer term strategy on UX. Color doesn't mean anything IMO

Also, since we use HTTPS-Only mode, every site that is not HTTPS is going to have an interstitial (for those that are excepted, then at least on the first visit), so I fail to see what coloring up the icon will do

declining

@rusty-snake
Copy link
Contributor

IIRC the reason was/is to mark unsafe sites as unsafe instead of safe sites as safe as safe (https) is/should be the default in the web. Therefore the color moved from green/safe to red/unsafe.

@Thorin-Oakenpants
Copy link
Contributor

right .. i'm not going to bother digging up the comments from bugzilla, but that's it from memory - i.e instead of checking for green (which is over half the internet's top sites and something like 80% of traffic), you should be noticing red (was less frequent) - i.e the change is more noticeable

@rusty-snake
Copy link
Contributor

security.secure_connection_icon_color_gray

And FF 100 is going to remove it.

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented May 3, 2022

yeah I noticed that and was going to find this issue to mention it

https://bugzilla.mozilla.org/show_bug.cgi?id=1756609 (emphasis mine)

this is actually still working. However, we can still remove it since we don't ship with the green lock icon anymore

@IkelAtomig
Copy link
Author

security.secure_connection_icon_color_gray

And FF 100 is going to remove it.

No, I need it. Just Updated Firefox and noticed things. Need to fix Overrides.

@Thorin-Oakenpants
Copy link
Contributor

you can most likely use userChrome.css and base64 if you want to - don;t ask me, try at r/firefoxcss

@Thorin-Oakenpants
Copy link
Contributor

also perhaps watch https://old.reddit.com/r/firefox/comments/uhqt6p/changing_securitysecure_connection_icon_color/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants