Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion: redo 2800s shutdown #45

Closed
Thorin-Oakenpants opened this issue Mar 9, 2017 · 5 comments
Closed

discussion: redo 2800s shutdown #45

Thorin-Oakenpants opened this issue Mar 9, 2017 · 5 comments

Comments

@Thorin-Oakenpants
Copy link
Contributor

The shutdown section needs a some love. Using words like "stuff" in 2803 is lame. I'm also not happy with the 2803a and 2804a numbering. Those 2 prefs need to be clarified exactly what they are doing as well. Especially 2803a, because we are shutting down, so how can that differ from what is already in 2803. As for 2804a, does it close current tabs/windows (but leave FF open) or what. I need to do some testing in a nilla FF.

Also, the section header could expanded a tad to explain clearing session data vs keeping it - a bit like the new 0800 (forms etc) section.

@Atavic
Copy link

Atavic commented Mar 9, 2017

/* 2802: enable FF options to clear stored data on close

/* 2803: list of items to clear on shutdown

@earthlng
Copy link
Contributor

earthlng commented Mar 9, 2017

Those 2 prefs need to be clarified exactly what they are doing as well

They are not available in the GUI so maybe they will get removed soon or who knows.
As far as I'm concerned they are there for completeness sake and if some end-user feels like enabling/testing them, they are free to do so. The pref-names are already pretty self-explanatory so IMO they don't need any more clarification.

Also, the section header could expanded a tad to explain clearing session data vs keeping it

Honestly I like it the way it is - it's pretty clear what it does. But if you think you can make it better then by all means. better is always better.
I sometimes thought if it wouldn't be better to move f.e. the 2 cookie-prefs into the cookie section, etc.
It would make more sense in a way, but it's also nice to have them all together. maybe something to think about.

@Just-me-ghacks
Copy link

Just-me-ghacks commented Mar 10, 2017

when I enable them, I get weird behavior when restarting, due to an addon no doubt - eg if I enable 2803a, on restart I get two window launches

Same thing here. I don't think it's an extension related issue.

@Atavic
Copy link

Atavic commented Mar 10, 2017

  • privacy.clearOnShutdown.openWindows

Is related to the Sessions Recovery that has been killed.
In K-Meleon Browser there's a Menu entry Sessions > Undo Last Closed.
If the entry value is true, you can't restore any session.

  • privacy.cpd.openWindows and privacy.cpd.siteSettings

Both entries are not available if you click on Settings in about:preferences#privacy

The available choices are

browsing & download
cookies
login
cache
form & search history
prefs
offline data

and once picked, turn the entries in about:config to true, while those two entries remain set to false.
Bad choices?

@earthlng
Copy link
Contributor

earthlng commented Mar 11, 2017

Patch for nits/comments

Our default settings contain no nasty surprises

Clearing the history can be quite nasty - as some earlier comments on ghacks have clearly shown.
Our default settings reflect the way that YOU are using them but if someone doesn't know why and what exactly your way is (fe. block all cookies, allow cookies per domain in siteSettings, and hence don't clear those out) it's just confusing. Pylly has it easier because they can clear everything, while our approach is just not very clear. For example I feel we could make all the cpd's true by default so they'll all be pre-checked. Do you know what I'm trying to say here?

[NOTE] The values 5 + 6 are not listed in the dropdown

0 is better than 5 or 6, and since they are not in the UI (yet?), it's neat to have that info but it can also be a problem if someone fe. sets that pref to 6 and then one day that doesn't do anything anymore. If it's not in the UI we shouldn't encourage or even point out that there are "hidden" values. You know what I mean?

The rest is okay, except the removal of openWindows for completeness sake, but they are default false anyway in FF, so yeah, zero fucks given. (our new motto 'member)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants