various, #959 #967
Merged
various, #959 #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `0105e` - we disable AS, and clearing the default does not stop someone adding their own (it's a different pref) should they chose to use AS - otherwise, to get rid of the topsites when clicking in an empty urlbar, users have to either know about this pref or enable AS and go manually remove them all - this is cleaner than disabling topsites with `browser.newtabpage.activity-stream.default.sites` as that actually breaks the functionality (should users want to use AS and topsite suggestions) - we don't disable topsite suggestions: 0850a: 78+, `browser.urlbar.suggest.topsites` is inactive: but if a user does want to disable that - 0850a - we could elaborate that this is for suggestions when you start typing/pasting (i.e not the same as topsites) - IDK - settings (changed) - we can remove these two when ESR68 hits EOL, meanwhile I just tagged them as (FF72-) - settings (not changed) - `0517` does not seem to exist: [SETTING] Privacy & Security>Forms and Autofill>Autofill addresses (FF74+) - I tested vanilla profiles in 74+, and system addon `formautofill@mozilla.org.xpi` is present - maybe I'm doing something wrong - `0420`: ui.PRM - maybe you can word it better
|
@guser-sudo feel free to join in |
rusty-snake
reviewed
Jul 4, 2020
| @@ -175,7 +178,7 @@ user_pref("javascript.use_us_english_locale", true); // [HIDDEN PREF] | |||
| /* 0212: enforce fallback text encoding to match en-US | |||
| * When the content or server doesn't declare a charset the browser will | |||
| * fallback to the "Current locale" based on your application language | |||
| * [SETTING] General>Language and Appearance>Fonts and Colors>Advanced>Text Encoding for Legacy Content | |||
| * [SETTING] General>Language and Appearance>Fonts and Colors>Advanced>Text Encoding for Legacy Content (FF72-) | |||
There was a problem hiding this comment.
Suggested change
| * [SETTING] General>Language and Appearance>Fonts and Colors>Advanced>Text Encoding for Legacy Content (FF72-) | |
| * [SETTING] General>Language and Appearance>Fonts and Colors>Advanced>Text Encoding for Legacy Content [FF72-] |
| @@ -205,7 +208,7 @@ user_pref("app.update.auto", false); | |||
| // user_pref("extensions.getAddons.cache.enabled", false); | |||
| /* 0308: disable search engine updates (e.g. OpenSearch) | |||
| * [NOTE] This does not affect Mozilla's built-in or Web Extension search engines | |||
| * [SETTING] General>Firefox Updates>Automatically update search engines ***/ | |||
| * [SETTING] General>Firefox Updates>Automatically update search engines (FF72-) ***/ | |||
There was a problem hiding this comment.
Suggested change
| * [SETTING] General>Firefox Updates>Automatically update search engines (FF72-) ***/ | |
| * [SETTING] General>Firefox Updates>Automatically update search engines [FF72-] ***/ |
There was a problem hiding this comment.
square brackets are only for numbered items of or individual prefs, search for (FF and you'll see what I mean
|
|
|
what about |
|
re: 0517 - I tested it in a vanilla FF78. Because by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0105ebrowser.newtabpage.activity-stream.default.sitesas that actually breaks the functionality (should users want to use AS and topsite suggestions)browser.urlbar.suggest.topsitesis inactive0517does not seem to exist: [SETTING] Privacy & Security>Forms and Autofill>Autofill addresses (FF74+)formautofill@mozilla.org.xpiis present0420: ui.PRM