This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 100
Zcash-style serialization for BLS12-381 #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: kevaundray <37423678+kevaundray@users.noreply.github.com>
Pratyush
reviewed
Oct 11, 2022
Pratyush
reviewed
Oct 11, 2022
Pratyush
reviewed
Oct 11, 2022
Pratyush
reviewed
Oct 11, 2022
They are more involved than serialization, and it's easier to manage separate functions
Will error if there's not enough space
Pratyush
reviewed
Oct 16, 2022
Pratyush
reviewed
Oct 16, 2022
Pratyush
reviewed
Oct 16, 2022
Pratyush
reviewed
Oct 16, 2022
btw I think there's no need to feature-gate the new compression. We can just leave a note in the CHANGELOG about this being a breaking change. |
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
as per code review
daira
reviewed
Oct 17, 2022
daira
reviewed
Oct 17, 2022
bls12_381/src/curves/g1.rs
Outdated
if compress == Compress::Yes { | ||
G1_SERIALISED_SIZE | ||
} else { | ||
G1_SERIALISED_SIZE * 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that Zcash always uses compressed point encodings, so the uncompressed version should not be referred to as Zcash-style encoding in documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pratyush
reviewed
Oct 19, 2022
Pratyush
reviewed
Oct 19, 2022
Pratyush
reviewed
Oct 19, 2022
Pratyush
approved these changes
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapted from https://github.com/crate-crypto/small-powers-of-tau/blob/master/src/interop_point_encoding.rs to take advantage of flexible serialization for curves.
Question: should we maybe have this mode of serialization feature-gated, e.g.:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer