This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 100
Implement WB hash2curve for BLS12-377 and BLS12-381 #138
Merged
mmagician
merged 64 commits into
arkworks-rs:master
from
w3f:skalman-bls12-377-wb-hash2curve
Jan 10, 2023
Merged
Implement WB hash2curve for BLS12-377 and BLS12-381 #138
mmagician
merged 64 commits into
arkworks-rs:master
from
w3f:skalman-bls12-377-wb-hash2curve
Jan 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improvement to WB hash to curve code for BLS12-377 - Update sage code for generating isogeny coefficients for arkworks.
- fix the polynomial coeffcient order for bls12-381 g1 and g2 isogenies. - fix the polynomial coeffcient order for bls12-377 g1. 377-g2 needs to be fixed still.
…12-377-wb-hash2curve - make bls12_377 implementation compatible with the upgrade. - bls12_377 builds
- delete auxiliary isogeny coeff file
…-377 - Do not use auxiliary constants to define generators of g2_swu_iso curve. - Update change log
@dishport as @Pratyush said, I think the first step is address this issue zhenfeizhang/indifferentiable-hashing#3 and then we can do a PR to algebra. |
should be semicolon not comma
no actual test vectors yet
parameters of endomorphisms are wrong for now
- Move PR 138 to Improvements section of CHANGELOG.md
Add test suites, adapt `zeta` for BLS12-377
mmagician
approved these changes
Jan 10, 2023
I manually checked that the
|
@drskalman, @Pratyush, this issue was succesfully addressed. Could you now add the new hash function to arkworks ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #18
Implementation Wahby - Bonneh Hash to curve for BLS12-377 and BLS12-381. The implementation of BLS12-381 is the same as the one found in the algebra/test-curves. The PR has been reviewed previously by @Pratyush @mmagician here
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer