Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Implement WB hash2curve for BLS12-377 and BLS12-381 #138

Merged
merged 64 commits into from
Jan 10, 2023
Merged

Implement WB hash2curve for BLS12-377 and BLS12-381 #138

merged 64 commits into from
Jan 10, 2023

Conversation

drskalman
Copy link
Contributor

@drskalman drskalman commented Dec 20, 2022 •
edited

Description

closes #18

Implementation Wahby - Bonneh Hash to curve for BLS12-377 and BLS12-381. The implementation of BLS12-381 is the same as the one found in the algebra/test-curves. The PR has been reviewed previously by @Pratyush @mmagician here

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests: BLS12-381 has tests, comprehensive test for BLS12-377 by @mmagician.
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

drskalman and others added 30 commits October 14, 2021 20:11
@drskalman
include the coefficients of bls12-377 G1 and G2 isogenies for wb hash…
533d160 
…2curve
@drskalman
replacing the ark-ec dependency to w3f/arkworks-algebra
3d1a539
@drskalman
added parameters for isogenous curve to bls12-377 g1 curve for swu map
da53a6b
@drskalman
fix dependency inconsistency problem
302975e
@drskalman
implement WBParams and its isogenous curve for BLS12-377 G1
711f426
@drskalman
implement the SWUParameters for isogenous curve to BLS12-377 g2 curve.
d8a5e79
@drskalman
implement WBParams for BLS12-377 G2 curve
95c4cb2
@drskalman
replacing const generic arrays with const slice in g1 and g2 iso coef…
f2804a8 
…ficients
@drskalman
- Implement WB hash to curve for BLS12-381 G1
9c1d38d 
- Improvement to WB hash to curve code for BLS12-377
- Update sage code for generating isogeny coefficients for arkworks.
@drskalman
Implement WB hash to curve for BLS12-381 G2
2b52206
@drskalman
- fix the bug with base order for field_new for Fq2
2e57d74 
- fix the polynomial coeffcient order for bls12-381 g1 and g2 isogenies.
- fix the polynomial coeffcient order for bls12-377 g1.
377-g2 needs to be fixed still.
@drskalman
fix bls12-377 wb hash to curve isogeny coeffcients
a22aa14
@drskalman
fixed sage code for generating the isogeny coefficients
88016a9
@drskalman
Merge branch 'master' into skalman-bls12-377-wb-hash2curve
911cdb8
@drskalman
Merge remote-tracking branch 'origin/master' into skalman-bls12-377-w…
c51717e 
…b-hash2curve
@drskalman
use patch.crates-io hack to resolve dependancy issues on w3f fork
26c3d50
@Pratyush
Rename Parameters to Config for all fields
c40d426
@Pratyush
Rename field_new to MontFp
62e98b7
@Pratyush
Rename field_new to QuadExt and CubicExt
e8d3b36
@drskalman
- Merge remote-tracking branch 'upstream/upgrade-ff' into skalman-bls…
2cc194e 
…12-377-wb-hash2curve

- make bls12_377 implementation compatible with the upgrade.
- bls12_377 builds
@drskalman
Refactor bls12_381 crate based on update-ff branch. Close #9
181f974
@drskalman
Merge branch 'master' into skalman-bls12-377-wb-hash2curve
4ec6ca4
@drskalman
adapt bls12 wb hashing to new changes in algebra
5c0780d
@drskalman
update bls12-381 dependancies and g1, g2 definition to pass tests
157e3ec
@drskalman
adapt bls12-377 hash to curve to algebar updates
7884e6e
@drskalman
depend on upstream for pull request
de51dab
@drskalman
cargo fmt
fc0b092
@drskalman
- move the isogeny finder script from sage to script folder
4555710 
- delete auxiliary isogeny coeff file
@drskalman
add unit tests for wb hashing to bls12-377 g1 and g2
f7176b2
@drskalman
- Use IsogenyMap struct to specify WB Isogeny for bls12-381 and bls12…
86ec5aa 
…-377

- Do not use auxiliary constants to define generators of g2_swu_iso curve.
- Update change log
@drskalman
Copy link
Contributor Author

@dishport as @Pratyush said, I think the first step is address this issue zhenfeizhang/indifferentiable-hashing#3 and then we can do a PR to algebra.

drskalman and others added 18 commits December 23, 2022 10:32
@drskalman
Merge branch 'master' into skalman-bls12-377-wb-hash2curve
87d9db0
@mmagician
Merge branch 'master' into h2c-test-templates
8e3f8b8
@mmagician
Merge branch 'h2c-test-templates' into skalman-bls12-377-wb-hash2curve
1889fff
@mmagician
Fix macro invocation
4a9280c 
should be semicolon not comma
@mmagician
curves master should use algebra/r1cs default branch
7dcf144
@mmagician
Merge branch 'h2c-test-templates' into skalman-bls12-377-wb-hash2curve
9ecc17f
@mmagician
Add h2c test invocation for bls12-377 curve
b546710 
no actual test vectors yet
@mmagician
add faster cofactor clearing and tests for g1
83c8963
@mmagician
add faster cofactor clearing and tests for g2
a00563d 
parameters of endomorphisms are wrong for now
@mmagician
add test vectors for bls12-377
2dedb93
@mmagician
add h_eff to g2 tests for correctness
8b9ec01 
test
@mmagician
improve cofactor tests g2
802b519
@mmagician
add a test for psi(psi(P)) == psi2(P)
d4586c0
@mmagician
fix bls12-377 psi & psi2 computation parameters
652d3ab
@mmagician
rename const to DOUBLE_P_POWER_ENDOMORPHISM_COEFF_0 and make private
6fd8c0c
@mmagician
fix clippy warnings in changed code
082c708
@mmagician
Merge branch 'cofactor-clearing-bls12-377' into bls12-h2c
54ba898
@mmagician
use the same zeta as test suites
ecd61b7
@mmagician mmagician mentioned this pull request Jan 1, 2023
Open
@mmagician
Copy link
Member

I manually checked that the h2c tests are executed:

...
test curves::tests::g1_h2c::test_h2c ... ok
...

@mmagician mmagician merged commit bf8c488 into arkworks-rs:master Jan 10, 2023
@Dimitri-Koshelev
Copy link

@dishport as @Pratyush said, I think the first step is address this issue zhenfeizhang/indifferentiable-hashing#3 and then we can do a PR to algebra.

@drskalman, @Pratyush, this issue was succesfully addressed. Could you now add the new hash function to arkworks ?

@drskalman drskalman deleted the skalman-bls12-377-wb-hash2curve branch February 7, 2023 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@mmagician mmagician mmagician approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hashing to curves
4 participants
@drskalman @mmagician @Dimitri-Koshelev @Pratyush