Serialize and Deserialize Uncompressed #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobigurk
reviewed
Feb 17, 2020
algebra/src/serialize/mod.rs
Outdated
| &self, | ||
| output_buf: &mut [u8], | ||
| ) -> Result<(), crate::serialize::SerializationError> { | ||
| let len = <Self as CanonicalSerialize>::buffer_size(); |
There was a problem hiding this comment.
What about using the field buffer size here instead?
There was a problem hiding this comment.
Good idea, fixed: 3039fc1#diff-40da71ffac4550ada607d2de65a09100R164
|
Also seems like it needs |
gakonst
force-pushed
the
serialize-uncompressed
branch
from
aa27a82
to
3039fc1
Compare
|
What do you think about adding these as new methods on the |
|
This would mean we'd need to implement the uncompressed methods for Fields as well which I wanted to avoid since I did not need it anywhere (and did not see when it'd be used). When would (de)serializing uncompressed fields be useful? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a new serialization trait which directly serializes a group element in its uncompressed form. In addition, I found it reasonable to add the serialization trait bounds in the
AffineCurvetrait.