Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'github.com/gorilla/websocket' to 'go.mod' file #36

Closed
ShoshinNikita opened this issue Nov 16, 2020 · 1 comment · Fixed by #39
Closed

Add 'github.com/gorilla/websocket' to 'go.mod' file #36

ShoshinNikita opened this issue Nov 16, 2020 · 1 comment · Fixed by #39

Comments

@ShoshinNikita
Copy link
Contributor

First, thank you for the great tool! It really helps to visualize and analyze runtime stats

I noticed that package websocket is a copy of github.com/gorilla/websocket. I would suggest to remove it from the repo and add to go.mod file. Even if there are some changes, it's better to create a fork. What do you say?

@arl
Copy link
Owner

arl commented Dec 1, 2020

When I started the project, statsviz http handlers were installed with an init, _ import like you'd do with net/http/pprof handlers. I wanted the library to be self-contained that's why I included websocket in the codebase.
I think you're right, now that's not useful anymore and it can even be counterproductive for projects which already import websocket as they would have a duplicate dependency.
Will add this to go.mod.

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants