-
Notifications
You must be signed in to change notification settings - Fork 134
/
podspec.go
184 lines (163 loc) · 5.56 KB
/
podspec.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
package validation
import (
"github.com/pkg/errors"
v1 "k8s.io/api/core/v1"
"k8s.io/component-helpers/scheduling/corev1/nodeaffinity"
"github.com/armadaproject/armada/internal/armada/configuration"
"github.com/armadaproject/armada/internal/common/armadaerrors"
"github.com/armadaproject/armada/internal/common/types"
)
func ValidatePodSpec(spec *v1.PodSpec, schedulingConfig *configuration.SchedulingConfig) error {
if spec == nil {
return errors.Errorf("empty pod spec")
}
if uint(spec.Size()) > schedulingConfig.MaxPodSpecSizeBytes {
return errors.Errorf("pod spec has a size of %v bytes which is greater than the maximum allowed size of %v", spec.Size(), schedulingConfig.MaxPodSpecSizeBytes)
}
if len(spec.Containers) == 0 {
return errors.Errorf("pod spec has no containers")
}
err := validateAffinity(spec.Affinity)
if err != nil {
return err
}
err = validateTerminationGracePeriod(spec, schedulingConfig)
if err != nil {
return err
}
for _, container := range spec.Containers {
if len(container.Resources.Limits) == 0 {
return errors.Errorf("container %v has no resource limits specified", container.Name)
}
if len(container.Resources.Requests) == 0 {
return errors.Errorf("container %v has no resource requests specified", container.Name)
}
err = validateContainerResource(container.Resources.Limits, schedulingConfig.MinJobResources, container.Name, "limit")
if err != nil {
return err
}
err = validateContainerResource(container.Resources.Requests, schedulingConfig.MinJobResources, container.Name, "request")
if err != nil {
return err
}
if !resourceListEquals(container.Resources.Requests, container.Resources.Limits) {
return errors.Errorf("container %v does not have resource request and limit equal (this is currently not supported)", container.Name)
}
}
return validatePorts(spec)
}
func validateTerminationGracePeriod(spec *v1.PodSpec, config *configuration.SchedulingConfig) error {
specHasTerminationGracePeriod := spec.TerminationGracePeriodSeconds != nil
var terminationGracePeriodSeconds int64
var exceedsBounds bool
if specHasTerminationGracePeriod {
terminationGracePeriodSeconds = *spec.TerminationGracePeriodSeconds
exceedsBounds = (terminationGracePeriodSeconds < int64(config.MinTerminationGracePeriod.Seconds()) ||
terminationGracePeriodSeconds > int64(config.MaxTerminationGracePeriod.Seconds()))
}
if exceedsBounds {
return errors.Errorf("terminationGracePeriodSeconds of %v must be in [%d, %d]s, or omitted",
terminationGracePeriodSeconds,
int64(config.MinTerminationGracePeriod.Seconds()),
int64(config.MaxTerminationGracePeriod.Seconds()),
)
}
return nil
}
func validateContainerResource(
resourceSpec v1.ResourceList,
minJobResources v1.ResourceList,
containerName string,
requestType string,
) error {
for rc, containerRsc := range resourceSpec {
serverRsc, nonEmpty := minJobResources[rc]
if nonEmpty && containerRsc.Value() < serverRsc.Value() {
return errors.Errorf(
"[validateContainerResource] container %q %s %s (%s) below server minimum (%s)",
containerName,
rc,
requestType,
&containerRsc,
&serverRsc,
)
}
}
return nil
}
func validateAffinity(affinity *v1.Affinity) error {
if affinity == nil {
return nil
}
nodeAffinity := affinity.NodeAffinity
if nodeAffinity == nil {
return nil
}
err := validatePreferredNodeAffinityNotPresent(nodeAffinity.PreferredDuringSchedulingIgnoredDuringExecution)
if err != nil {
return err
}
return validateRequiredNodeAffinity(nodeAffinity.RequiredDuringSchedulingIgnoredDuringExecution)
}
func validatePreferredNodeAffinityNotPresent(preferred []v1.PreferredSchedulingTerm) error {
if preferred != nil && len(preferred) > 0 {
return errors.New("PreferredDuringSchedulingIgnoredDuringExecution node affinity is not supported by Armada")
}
return nil
}
func validateRequiredNodeAffinity(required *v1.NodeSelector) error {
if required == nil {
return nil
}
_, err := nodeaffinity.NewNodeSelector(required)
if err != nil {
return errors.Errorf("invalid RequiredDuringSchedulingIgnoredDuringExecution node affinity: %v", err)
}
return nil
}
func resourceListEquals(a v1.ResourceList, b v1.ResourceList) bool {
if len(a) != len(b) {
return false
}
for k, v := range a {
if v != b[k] {
return false
}
}
return true
}
func validatePorts(podSpec *v1.PodSpec) error {
existingPortSet := make(map[int32]int)
for index, container := range podSpec.Containers {
for _, port := range container.Ports {
if existingIndex, existing := existingPortSet[port.ContainerPort]; existing {
return errors.Errorf(
"container port %d is exposed multiple times, specified in containers with indexes %d, %d. Should only be exposed once",
port.ContainerPort, existingIndex, index)
} else {
existingPortSet[port.ContainerPort] = index
}
}
}
return nil
}
func validatePodSpecPriorityClass(podSpec *v1.PodSpec, preemptionEnabled bool, allowedPriorityClasses map[string]types.PriorityClass) error {
priorityClassName := podSpec.PriorityClassName
if priorityClassName != "" {
if !preemptionEnabled {
return errors.WithStack(&armadaerrors.ErrInvalidArgument{
Name: "PriorityClassName",
Value: podSpec.PriorityClassName,
Message: "Preemption is disabled in Server config",
})
}
if _, exists := allowedPriorityClasses[priorityClassName]; !exists {
return errors.WithStack(&armadaerrors.ErrInvalidArgument{
Name: "PriorityClassName",
Value: podSpec.PriorityClassName,
Message: "Specified Priority Class is not supported in Server config",
})
}
}
return nil
}