git: do not update/checkout with root privileges #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang Ning <832666+zhangn1985@users.noreply.github.com>
|
Thank you @zhangn1985! |
| declare -f update_src >> $TMPFILE | ||
| echo update_src >> $TMPFILE | ||
|
|
||
| #do not update/checkout git with root privileges to messup files onwership. |
There was a problem hiding this comment.
But only inside Docker. For native it shall remain unchanged. What do you think?
There was a problem hiding this comment.
no. for bare metal, it should not use root to git pull/checkout, otherwise wrong file ownership.
There was a problem hiding this comment.
We pull to understand if there are changes upstream. This is must have. Sadly we need root / privileged mode for building images. Not for kernel.
Related?
https://forum.armbian.com/topic/11747-q-bash-cannot-set-terminal-process-group-at-compilesh/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhang Ning 832666+zhangn1985@users.noreply.github.com