Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change rock-3a mainline dtb filename to rk3568-rock-3a.dtb #3775

Merged

Conversation

amazingfate
Copy link
Contributor

Description

Devicetree of rock3a has get merged to linux-next with filename rk3568-rock-3a.dts. Change the filename to keep up with mainline kernel.

Jira reference number [AR-9999]

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Rock3a edge image can boot up

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@amazingfate
Copy link
Contributor Author

@catalinii @igorpecovnik
This commit changes the dtb filename, but doesn't change the dtb filename in /boot/armbianEnv.txt. So the update of deb package linux-dtb on old image will cause board not up.

@piter75
Copy link
Member

piter75 commented May 9, 2022

@catalinii @igorpecovnik
This commit changes the dtb filename, but doesn't change the dtb filename in /boot/armbianEnv.txt. So the update of deb package linux-dtb on old image will cause board not up.

You could add a link from an old name to the new one (with a corresponding entry in the DTB makefile) to help in the transition process - similar to this approach.

@amazingfate
Copy link
Contributor Author

@catalinii @igorpecovnik
This commit changes the dtb filename, but doesn't change the dtb filename in /boot/armbianEnv.txt. So the update of deb package linux-dtb on old image will cause board not up.

You could add a link from an old name to the new one (with a corresponding entry in the DTB makefile) to help in the transition process - similar to this approach.

I create a symlink, but the deb packages linux-dtb-edge-rk35xx doesn't have rk3568-rock-3-a.dtb.

@igorpecovnik
Copy link
Member

doesn't have rk3568-rock-3-a.dtb.

So don't remove it from Makefile ;)

@amazingfate
Copy link
Contributor Author

doesn't have rk3568-rock-3-a.dtb.

So don't remove it from Makefile ;)

Makefile is updated.

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label May 10, 2022
@igorpecovnik igorpecovnik merged commit 68729a3 into armbian:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviewed, tested and ready for merge
Development

Successfully merging this pull request may close these issues.

3 participants