Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Innovato TV box as TVB target #4950

Closed
wants to merge 1 commit into from
Closed

Add Innovato TV box as TVB target #4950

wants to merge 1 commit into from

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Mar 15, 2023

Description

Split adding a board with reworking patches for Opi3 and Opi3LTS that are preventing this hw from functional lan / audio.

Jira reference number AR-1487

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Mar 15, 2023
@SteeManMI
Copy link
Contributor

It the inovato box just a rebranded/cloned tanix tx6 box? I see you are using the tanix tx6 dtb's and making changes to them. I wonder if a new dtb needs to be created for the inovato box?
I think I have a tanix tx6 box sitting around, so I will test this on that box once this is merged in as I am curious as to how generic these changes are.

@igorpecovnik
Copy link
Member Author

It the inovato box just a rebranded/cloned tanix tx6 box?

Yes, looks like. I don't have this hw, others are testing.

@rpardini
Copy link
Member

I see you are using the tanix tx6 dtb's and making changes to them.

Indeed, doesn't these patches actually break the Tanix? If so, we should probably create new Innovato DTS, #include the Tanix DTS and "overlay" the changes?

(I have similar "kidnapping" of a Vega 96 into a T95Z for meson64, but that lives in my userpatches, I won't PR it until I find time to do it properly/as explained above)...

@igorpecovnik
Copy link
Member Author

Re-do without interfering with Tanix Tv box.

@SteeManMI
Copy link
Contributor

I'm curious why only legacy and not current or edge?

@igorpecovnik
Copy link
Member Author

I'm curious why only legacy and not current or edge?

We will get there eventually ;) WiFi doesn't work in 6.0+ as this has to be re-worked
#4682

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress and removed Ready to merge Reviewed, tested and ready for merge labels Mar 16, 2023
@inovato-llc
Copy link

inovato-llc commented Apr 2, 2023

I tested this patch over freshly cloned main yesterday. There are two different issues:

First, it seems the intent of this patch is to avoid the conflicting patches for the OP3LTS board by loading a linux DTS with no #includes that reference the patches made to the family DTS/DTSI files made by the OP3LTS patches (these start with 0009 and 0011). However, this doesn't work - they still get pulled in. These seems impossible unless u-boot is passing in the u-boot DTB instead of the Linux DTB. The u-boot DTB still has the tanix include which ultimately pullls these in. Is this possible? Or is there some other way the OP3LTS patches are getting pulled in?

I confirmed it is the OP3STS patches breaking things by disabling the above OP3 patches and the problem goes away and AC200 ethernet works.

On a side note, the included linux DTS has phandle references that generate pages of warnings and get replaced by the compiler. This seems cosmetic, but messy?

Unfortunately, this is above my ability to fix. Could someone look into this?

Second, there are 5 Kernel config changes that have to be made to get the AC200 PHY and XR819 driver to work. These are:

To prevent XR819 radio crashes - all boards using XR819 will need this):

# CONFIG_VMAP_STACK is not set

The following for Ethernet:

CONFIG_AC200_PHY=y
CONFIG_REGULATOR_PWM=y
# CONFIG_SND_SOC_ACX00 is not set
CONFIG_PWM_SUN4I=y

One other request: I understand the idea behind using .TVB for devices that ship as TV Boxes and have to be reflashed to Armbian. However, this is not the case with the Inovato Quadra. While it shares hardware with a TV Box, it comes factory flashed to Armbian. So it never exists as a TV Box. I'd like to request that this be a CSC board so it isn't confusing to users making them think they somehow have to reflash it.

So to summarize, I can confirm that this all works if the above kernel config changes are made and I disable the OP3LTS patches. So at least there are no other lurking issues if these can get solved.

@igorpecovnik
Copy link
Member Author

Coming in with #5726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants