-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve i3-wm support #5188
Improve i3-wm support #5188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Odroid N2. Works as expected, 1st config, wallpaper, tried few things ... I think we are ready to roll with this.
@@ -1,5 +1,6 @@ | |||
anacron | |||
apport-gtk | |||
apt-xapian-index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this change requires this additional package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably for fast application search when opening application launcher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while I was trying to build the image it has a step where it builds the Xapian index, since the package was not originally there, it wasn't installed, therefore failing the build process, it was listed in other desktop config_bases as well, so reused to ensure image builds without any issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably for fast application search when opening application launcher?
well yes, it generates an axi-cache, enabling a faster command search
@@ -63,6 +64,7 @@ i3 | |||
i3lock | |||
i3status | |||
i3-wm | |||
suckless-tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a requirement for i3-wm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes as the suckless-tools package includes packages needed to use i3-wm properly, like dmenu used for app/command execution
@@ -1 +1 @@ | |||
csc | |||
supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a single PR enough to change this from csc to supported? Who is going to maintain and test this going forward? I would think we would need someone to step up as an official maintainer for this with the responsibility to test for each release. Is that part of the expectation here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BeanGreen247 promised to take care of it.
This got approved quickly before I had time to comment, but I wanted to add the comments above anyway. |
I have merged this fast and more other things as I want to generate images for testing. Perhaps first RC today if everything goes well. |
I like it (once tested), curious if there's a reason to stick with i3 as opposed to Sway (Wayland). I've been using Sway since it will work on my i.mx8 boards |
Thomas approached to us asking if he can help out with something and his i3 experiments caught my attention. Our i3 desktop was never completely done ... this is how it started. If someone will pick up Sway, we can switch or have both. |
Description
This PR contains update to make creation of armbian i3-wm images possible for the following distributions listed by their code names.
Jira reference number AR-1708
How Has This Been Tested?
So far I have made sure that the images can be built and that they are bootable and functional. Testing was done on real hardware, bare metal.
Checklist:
Not sure what to mark exactly, so leaving most of these blank for now