Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymize default build engine settings #5865

Merged
merged 16 commits into from Nov 15, 2023
Merged

Anonymize default build engine settings #5865

merged 16 commits into from Nov 15, 2023

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Oct 25, 2023 •
edited

Description

Improve naming confusion by changing build framework defaults.

  • set framework defaults VENDOR to Armbian-unofficial for self build images
  • unsupported boards and unsupported distribution have framework defaults, except VENDOR and VENDORURL

We build images with predefined values.

Revision:       23.11.0-trunk
Board:          Bananapim2ultra
Kernel:         Linux 6.1.60 (current)
Build date:     06.11.2023
Sources:        git@github.com:armbian/build.git
Sources rev:    https://github.com/armbian/build/commit/72fc50c4b38297939cf502001078068671add72f-dirty
Authors:        https://www.armbian.com/authors
Maintainer:     John Doe <john.doe@somewhere.planet>
Support:        https://community.armbian.com/

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@igorpecovnik igorpecovnik requested a review from a team as a code owner October 25, 2023 20:10
@SteeManMI
Copy link
Contributor

I think this is a good first step.

igorpecovnik and others added 2 commits November 8, 2023 10:48
@igorpecovnik
Improve txt file inside OS and within image
800e267 
Title:          Armbian-unofficial
Revision:       23.11.0-trunk
Board:          Bananapim2ultra
Kernel:         Linux 6.1.60 (current)
Build date:     06.11.2023
Sources:        git@github.com:armbian/build.git
Sources rev:    72fc50c-dirty
Authors:        https://www.armbian.com/authors
Origin:         https://github.com/armbian/
Maintainer:     John Doe <john.doe@somewhere.planet>
Support:        https://duckduckgo.com/
@igorpecovnik
Merge branch 'main' into unbrand
4b21b82
@igorpecovnik igorpecovnik added Needs review Seeking for review Software labels Nov 15, 2023
@igorpecovnik igorpecovnik added the 11 Milestone: Fourth quarter release label Nov 15, 2023
viraniac
viraniac approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@viraniac viraniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Nov 15, 2023
@igorpecovnik igorpecovnik merged commit 6bcf74f into main Nov 15, 2023
7 checks passed
@igorpecovnik igorpecovnik deleted the unbrand branch November 15, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viraniac viraniac viraniac approved these changes

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Ready to merge Reviewed, tested and ready for merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@igorpecovnik @SteeManMI @viraniac