Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dts for mini-m8s-pro tvbox #6014

Merged
merged 4 commits into from Dec 6, 2023
Merged

Conversation

zerog2k
Copy link
Contributor

@zerog2k zerog2k commented Dec 6, 2023

Description

add dts for Mini M8s Pro tvbox (S912, 2G/16G), which is essentially same as Beelink GT1 Ultimate, but with QCA9377/LTM8830 Wifi/BT
Also for some re-branded tvboxes based on same hardware, e.g. LobbyTV

How Has This Been Tested?

Tested on my box. Boots, wifi & bt works.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Hardware Hardware related - kernel, u-boot, patches labels Dec 6, 2023
Copy link
Collaborator

@viraniac viraniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dts should be placed inside the dt subfolder. I am not sure if it can be directly placed in meson64-6.6 directory

@SteeManMI
Copy link
Contributor

Please indicate what is the upstream source of this dts file. (or if you have created it yourself, but given the copyright it seems you have gotten this from elsewhere). That way someone can track upstream changes and merge them in if there are any in the future.

@zerog2k
Copy link
Contributor Author

zerog2k commented Dec 6, 2023

The dts should be placed inside the dt subfolder. I am not sure if it can be directly placed in meson64-6.6 directory

yes, totally my bad - I copied this over after having to change branch bases, thanks for catching.
I'll push a commit to fix, (assuming it would get squash merged anyhow), but let me know if we need a new PR.

Please indicate what is the upstream source of this dts file. (or if you have created it yourself, but given the copyright it seems you have gotten this from elsewhere). That way someone can track upstream changes and merge them in if there are any in the future.

https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dts
it's just modifying the Beelink GT1 dts for wifi/bt.

@viraniac viraniac self-requested a review December 6, 2023 22:11
Copy link
Collaborator

@viraniac viraniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release labels Dec 6, 2023
@igorpecovnik igorpecovnik merged commit d2c928c into armbian:main Dec 6, 2023
11 checks passed
@zerog2k zerog2k deleted the mini-m8s-pro-dtb branch December 7, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Hardware Hardware related - kernel, u-boot, patches Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

None yet

4 participants