Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aml-s9xx-box: Remove u-boot and update generated extlinux.conf #6803

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

SteeManMI
Copy link
Contributor

Changes to be committed:
modified: config/boards/aml-s9xx-box.tvb
modified: packages/bsp/aml-s9xx-box/boot/extlinux/extlinux.conf.template

The aml-s9xx-box builds use the native TV Box u-boot. I've had as a todo item to figure out how to not build and include an unused u-boot. In a recent PR for a different board the opposite was being done (adding a u-boot where a board didn't previously ship one), thus I then had the info to remove it here.
This also changes the generated extlinux.conf to include a fdt line by adding the boot_fdt_file to the board config file. This reduces the effort needed to manually modify the extlinux.conf.

How Has This Been Tested?

  • Build aml-s9xx-box image and debs
  • Verify built contents

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

 Changes to be committed:
	modified:   config/boards/aml-s9xx-box.tvb
	modified:   packages/bsp/aml-s9xx-box/boot/extlinux/extlinux.conf.template

The aml-s9xx-box builds use the native TV Box u-boot.  I've had as a
todo item to figure out how to not build and include an unused u-boot.
In a recent PR for a different board the opposite was being done
(adding a u-boot where a board didn't previously ship one), thus
I then had the info to remove it here.
This also changes the generated extlinux.conf to include a fdt line
by adding the boot_fdt_file to the board config file.  This reduces
the effort needed to manually modify the extlinux.conf.
@SteeManMI SteeManMI requested a review from a team as a code owner June 26, 2024 02:45
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels Jun 26, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jun 27, 2024
@SteeManMI SteeManMI merged commit 87f37f6 into armbian:main Jun 27, 2024
11 checks passed
@SteeManMI SteeManMI deleted the remove-u-boot branch June 27, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

None yet

2 participants