Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.1版本初始化KVDB时重复上锁 #265

Closed
innovak opened this issue Nov 30, 2023 · 5 comments
Closed

2.1版本初始化KVDB时重复上锁 #265

innovak opened this issue Nov 30, 2023 · 5 comments

Comments

@innovak
Copy link

innovak commented Nov 30, 2023

2.1版本中:fdb_kvdb_init()在fdb_kvdb.c:1763行锁定了数据库,在1800行调用_fdb_kv_load(),后者在1649行再次锁定了数据库.似乎混淆了KVDB和cache的锁?
@KikyTokamuro
Copy link

I wanted to update to the new version, but I encountered the same error. Are there any fixes?

@armink
Copy link
Owner

armink commented Dec 1, 2023

确实，_fdb_kv_load 里的锁可以移除掉了呢，毕竟外面有锁了

你方便提交一个 PR 吗？

@armink
Copy link
Owner

armink commented Dec 1, 2023

I wanted to update to the new version, but I encountered the same error. Are there any fixes?

This issue seems to be a code simplification, but it will not affect the functionality.

@innovak
Copy link
Author

innovak commented Dec 1, 2023

确实，_fdb_kv_load 里的锁可以移除掉了呢，毕竟外面有锁了

你方便提交一个 PR 吗？

这边网络不太方便,您来修改吧.

@armink
Copy link
Owner

armink commented Dec 2, 2023

最新版本已更新

@armink armink closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@armink @innovak @KikyTokamuro