Skip to content
This repository has been archived by the owner on Feb 6, 2022. It is now read-only.

When playing preroll ads, sometimes the text appears very small #108

Closed
DoomTay opened this issue May 30, 2018 · 1 comment
Closed

When playing preroll ads, sometimes the text appears very small #108

DoomTay opened this issue May 30, 2018 · 1 comment

Comments

@DoomTay
Copy link
Contributor

DoomTay commented May 30, 2018

Sample set

This happens with a simple implementation of videojs-contrib-ads (heisenbug.html) and with videojs-vast-vpaid (heisenbug2.html), though the latter case is much, much rarer.

I noticed that when this happens, the style of span elements for subtitle lines are missing the font attribute. It seems that something about how both plugins set up ad playback interferes with span styling somehow, even though only one of them makes use of videojs-contrib-ads/

I'm not sure how to trace this further, but because it involves span styling, it seems this is a libjass issue.

@Arnavion
Copy link
Owner

Arnavion commented May 30, 2018

As the documentation says

After the renderer fires its ready event, libjass.renderers.WebRenderer.resize must be called to initialize its size before starting the clock.

However videojs-ass is starting the clock before calling resize, thus WebRenderer.preRender is getting called before its scaleX and scaleY properties have been initialized. videojs-ass needs to fix this.

(Edit: videojs -> videojs-ass)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants