Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features in roi_activity and pop_roi_connect + minor changes #14

Merged
merged 21 commits into from
Sep 30, 2022

Conversation

nguyen-td
Copy link
Collaborator

  • Connectivity can now be computed on time snippets
  • FOOOF included (beta version, still needs some adjustments)
  • GC/TRGC are computed via data2strcgmim
  • Colormap for matrix plots changed from cm17 to cm18

Major changes can be found in the slides attached
Gitpull_29092022.pdf

Test pipeline
tdn_test_pipeline.txt

@arnodelorme
Copy link
Collaborator

Changes look good, but 'foof' and 'foof_range' are not documented. Also about the Snippet calculation, is it equivalent to extracting 2 second epochs. pop_roi_activity was already extracting 2 second segments automatically (although it was also modifying the current dataset which is not necessarily ideal.

@fpellegrini
Copy link
Collaborator

fpellegrini commented Sep 30, 2022

Hi Arno, about the snippet analysis: No, it is not equivalent to the epoching. We discovered that the whole data length imposes a bias on the connectivity estimate. We therefore recommend using the same data length (i.e. snippet length, default = 1 minute) for all conditions that should be compared.
As in, if for example, we have 1 minute data in one condition and 2 minutes in the other condition, it would not be advisable to calculate connectivity on them as it is, but rather cut both data streams into 1 min snippets, calculate connectivity for each snippet separately, and then take either the mean across the two snippets in condition 2 or feed them into some statistical analysis as two different samples. The two-seconds epoching would be used either way.

@arnodelorme arnodelorme merged commit 3f4e7ff into sccn:master Sep 30, 2022
nguyen-td referenced this pull request in nguyen-td/roiconnect Oct 7, 2022
Merge pull request #14 from Hiyeri/master
arnodelorme pushed a commit that referenced this pull request Feb 1, 2023
Merge pull request #20 from Hiyeri/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants