Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate '.' in speech text #84

Closed
NSoiffer opened this issue Jun 16, 2018 · 3 comments
Closed

Eliminate '.' in speech text #84

NSoiffer opened this issue Jun 16, 2018 · 3 comments

Comments

@NSoiffer
Copy link
Collaborator

Description

I believe '.' and ',' were added to speech strings to cause the speech engine to add a little pause at that point. SSML is now being used, so the punctuation is not really appropriate as the times in the break are more precise. Furthermore, sometimes the speech engine will speak the ., which is bad.

An example where that happens is when a common fraction is spoken:

five eights <mark name="83earh"/> . <break time="150ms"/>

Perhaps because the . is along between two tags, it gets spoken by aws polly as "dot".

I suggest that all punctuation should be deleted. If SSML is not being used, then longer breaks should be converted to . and shorter ones to ,. That would be an easy thing to do in the code.

@arnog
Copy link
Owner

arnog commented Jun 16, 2018

I believe you're correct that the dot is voiced when it is in between two tags, or not clearly the end of a sentence (i.e. with a space before it instead of a word).
That said, a "." serves two purposes: adding a pause, but it also changes the intonation of the utterance, using a falling intonation. All the dots having to do with a pause should be removed and replaced with an appropriate tag. I'm not sure about those controlling the intonation.

@NSoiffer
Copy link
Collaborator Author

NSoiffer commented Jun 17, 2018 via email

@arnog
Copy link
Owner

arnog commented Dec 8, 2023

I believe the dots have been eliminated. If there are still some issues, please open a new issue with the specific cases that are causing problems.

@arnog arnog closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants