Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News mobs of the 1.13 ? #27

Closed
aurel85 opened this issue Oct 9, 2018 · 7 comments
Closed

News mobs of the 1.13 ? #27

aurel85 opened this issue Oct 9, 2018 · 7 comments

Comments

@aurel85
Copy link

aurel85 commented Oct 9, 2018

Hi,

Is it expected that the new mobs of the 1.13 (dolphins, turtles, phantom...) be added ?

@aurel85 aurel85 changed the title News mobs in 1.13 ? News mobs of the 1.13 ? Oct 9, 2018
@Arnuh
Copy link
Owner

Arnuh commented Oct 10, 2018

They should be added just maybe not in the selector/in the command hint thing? Which I don't even know how that works but I assume its config based.

They may be missing some things because I don't really keep up with minecraft and when updating didn't see much I could manipulate with from datawatcher objects.

@aurel85
Copy link
Author

aurel85 commented Dec 1, 2018

What about 2 months later ?

@Arnuh
Copy link
Owner

Arnuh commented Dec 1, 2018

Again, more specific on what's missing?

@aurel85
Copy link
Author

aurel85 commented Dec 1, 2018

Add the new mobs 1.13 in /pet selector

Arnuh added a commit that referenced this issue Dec 2, 2018
@aurel85
Copy link
Author

aurel85 commented Dec 2, 2018

With the latest version there are no new mobs 1.13 but against there are duplicates that have been added on page 2.

https://sandbox.fr/images/uploads/original/1543758224.png
https://sandbox.fr/images/uploads/original/1543758239.png

@Arnuh
Copy link
Owner

Arnuh commented Dec 2, 2018

I assume the 3 dupe eggs are vindicator, evoker, illusioner. Idk what spigot calls 'illusioner' so the spawn egg is set to vindicator ILLUSIONER(PetType.ILLUSIONER, Material.VINDICATOR_SPAWN_EGG
Also the selector UI is loaded via the config file so you either have to update it manually or just generate new config.yml and copy it over.

Although I can definitely look into checking what PetItems are missing in the config and automatically add them in a future commit.

@aurel85
Copy link
Author

aurel85 commented Dec 3, 2018

It's true, and I just did it so I will be able to close this problem, but yes, it might be a good idea to do it directly in the plugin in the near future.

Thank you for everything !

@aurel85 aurel85 closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants