Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the font handling parts from authors github repository #2

Merged
merged 2 commits into from
Oct 27, 2019

Conversation

wawatok
Copy link
Member

@wawatok wawatok commented Jun 9, 2019

source: https://github.co…m/wattoc/AROS-vpdf
omitted debug (for now).
fixes opening test documents by vpdf, tested working on i386.

@todo
Copy link

todo bot commented Jun 9, 2019

not sure if "symbol.ttf" is right

// TODO: not sure if "symbol.ttf" is right
{"Symbol", "s050000l.pfb", "symbol.ttf"},
{"Times-Bold", "n021004l.pfb", "timesbd.ttf"},
{"Times-BoldItalic", "n021024l.pfb", "timesbi.ttf"},
{"Times-Italic", "n021023l.pfb", "timesi.ttf"},
{"Times-Roman", "n021003l.pfb", "times.ttf"},


This comment was generated by todo based on a TODO comment in e52edfe in #2. cc @wawatok.

@todo
Copy link

todo bot commented Jun 9, 2019

not sure if "wingding.ttf" is right

// TODO: not sure if "wingding.ttf" is right
{"ZapfDingbats", "d050000l.pfb", "wingding.ttf"},
// those seem to be frequently accessed by PDF files and I kind of guess
// which font file do the refer to
{"Palatino", NULL, "pala.ttf"},


This comment was generated by todo based on a TODO comment in e52edfe in #2. cc @wawatok.

@todo
Copy link

todo bot commented Jun 9, 2019

make sure to scan all directories belonging to an assign

#define FONTS_SUBDIR "FONTS:" // TODO: make sure to scan all directories belonging to an assign
static bool FileExists(const char *path)
{
FILE *f = fopen(path, "rb");
if (f)


This comment was generated by todo based on a TODO comment in e52edfe in #2. cc @wawatok.

@todo
Copy link

todo bot commented Jun 9, 2019

handle some substitution rules here? */

/* TODO: handle some substitution rules here? */
return fontcache;
}
static struct fontpattern *buildFcPattern(struct fontpattern *p, GfxFont *font, GooString *base14Name)


This comment was generated by todo based on a TODO comment in e52edfe in #2. cc @wawatok.

@todo
Copy link

todo bot commented Jun 9, 2019

think what to do in this case */

if (match != NULL) /* TODO: think what to do in this case */
{
s = fcPatternGetString(match, EFC_FILE, 0);
s2 = fcPatternGetString(match, EFC_FULLNAME, 0);


This comment was generated by todo based on a TODO comment in e52edfe in #2. cc @wawatok.

@todo
Copy link

todo bot commented Jun 9, 2019

ok, this is silly and shouldn't happen i guess */

goto fin; /* TODO: ok, this is silly and shouldn't happen i guess */
if (!strncasecmp(ext,".ttf",4) || !strncasecmp(ext, ".ttc", 4))
{
int weight, slant;
GBool bold = font->isBold();


This comment was generated by todo based on a TODO comment in e52edfe in #2. cc @wawatok.

@todo
Copy link

todo bot commented Jun 9, 2019

not sure if "symbol.ttf" is right

// TODO: not sure if "symbol.ttf" is right
{"Symbol", "s050000l.pfb", "symbol.ttf"},
{"Times-Bold", "n021004l.pfb", "timesbd.ttf"},
{"Times-BoldItalic", "n021024l.pfb", "timesbi.ttf"},
{"Times-Italic", "n021023l.pfb", "timesi.ttf"},
{"Times-Roman", "n021003l.pfb", "times.ttf"},


This comment was generated by todo based on a TODO comment in 50b0a01 in #2. cc @wawatok.

@todo
Copy link

todo bot commented Jun 9, 2019

not sure if "wingding.ttf" is right

// TODO: not sure if "wingding.ttf" is right
{"ZapfDingbats", "d050000l.pfb", "wingding.ttf"},
// those seem to be frequently accessed by PDF files and I kind of guess
// which font file do the refer to
{"Palatino", NULL, "pala.ttf"},


This comment was generated by todo based on a TODO comment in 50b0a01 in #2. cc @wawatok.

@todo
Copy link

todo bot commented Jun 9, 2019

ok, this is silly and shouldn't happen i guess */

goto fin; /* TODO: ok, this is silly and shouldn't happen i guess */
if (!strncasecmp(ext,".ttf",4) || !strncasecmp(ext, ".ttc", 4))
{
int weight, slant;
GBool bold = font->isBold();


This comment was generated by todo based on a TODO comment in 50b0a01 in #2. cc @wawatok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants