Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Gray bars appear on mouse hover when "view by day" is selected #717

Closed
brandon-toner opened this issue Jan 27, 2024 · 6 comments
Closed

Comments

@brandon-toner
Copy link

brandon-toner commented Jan 27, 2024

Description: Gray bars appear on mouse hover when "view by day" is selected

See attached GIF for example of behaviour.
2024-01-27-1442 03_Screenshot

@brandon-toner brandon-toner changed the title Gray bars appear on mouse hover when "view by day" is selected [Bug] Gray bars appear on mouse hover when "view by day" is selected Jan 27, 2024
@arp242
Copy link
Owner

arp242 commented Jan 27, 2024

Can you tell me which browser you're using, and on which system? Thanks.

@brandon-toner
Copy link
Author

Sure thing:

  • Browser: Chrome Version 121.0.6167.85 (Official Build) (arm64)
  • System: MacOS 14.2 (23C64)

@brandon-toner
Copy link
Author

Reproduced in:

  • Firefox 122.0 (64-bit)
  • Safari 17.2 (19617.1.17.11.9)

@arp242
Copy link
Owner

arp242 commented Jan 27, 2024

Thanks. Looks like something goes wrong for bar charts with "view by day" selected but just a few days in the date range, so you have very wide bars.

It only breaks if you zoom; at zoom level 0 it's fine. I'm guessing your mac "zooms" automatically with its retina display(?)

Example: https://stats.arp242.net/?hl-period=week&period-start=2024-01-20&period-end=2024-01-27&filter=&daily=on

@paularmstrong
Copy link

It only breaks if you zoom; at zoom level 0 it's fine. I'm guessing your mac "zooms" automatically with its retina display(?)

Macs don't zoom on their own.

It looks like it may be likely that the mouseover implementation doesn't take into account the DPR that's initialized in charty when drawing the boxes for hovers:

if (isBar) {

@arp242 arp242 closed this as completed in 2ef87fd Apr 8, 2024
@arp242
Copy link
Owner

arp242 commented Apr 8, 2024

Okay, should be fixed. Let me know if you're still having problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants