Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtocolMetaData returned by Container is wrong when using PortForwarding #12

Closed
aslakknutsen opened this issue Nov 8, 2014 · 0 comments · Fixed by #13
Closed

ProtocolMetaData returned by Container is wrong when using PortForwarding #12

aslakknutsen opened this issue Nov 8, 2014 · 0 comments · Fixed by #13
Labels
Milestone

Comments

@aslakknutsen
Copy link
Member

The Container it self only knows which ports it is bound to inside the Docker image, not which ports are opened from the outside via PortForward.

This effects the ServletProtocol when attempting to communicate with incontainer test cases and @ArquillianResource URL injection.

aslakknutsen added a commit to aslakknutsen/arquillian-cube that referenced this issue Nov 8, 2014
The Container only knows about the ports it self is bound to,
not how Docker is remapping them from the outside.

When e.g. the Container is bound to port 8080 inside Docker
and Docker PortForward from external port 8081 to internal
8080 the ProtocolMetaData is of. This effects the ServletProtocol
which is attempting to use this information to communicate with
the in-container test case as well as URL injection on the client
side via @ArquillianResource.

When the ProtocolMetaData is created, the object is intercepted
bu Cube to update the data based on the port we know are being
forwarded.

fixes arquillian#12
@aslakknutsen aslakknutsen modified the milestone: alpha1 Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant