Remap the ports returned by the Container in the ProtocolMetaData #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Container only knows about the ports it self is bound to, not how Docker is remapping them from the outside. When e.g. the Container is bound to port 8080 inside Docker and Docker PortForward from external port 8081 to internal 8080 the ProtocolMetaData is of. This effects the ServletProtocol which is attempting to use this information to communicate with the in-container test case as well as URL injection on the client side via @ArquillianResource. When the ProtocolMetaData is created, the object is intercepted bu Cube to update the data based on the port we know are being forwarded. fixes arquillian#12
|
So now I understand why initially when I used @ArquillianResource it works because the ports where the same. This is a lesson I have learned in cube, do your tests with different ports, it will be more secure :) |
lordofthejars
added a commit
that referenced
this pull request
Nov 8, 2014
Remap the ports returned by the Container in the ProtocolMetaData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Container only knows about the ports it self is bound to,
not how Docker is remapping them from the outside.
When e.g. the Container is bound to port 8080 inside Docker
and Docker PortForward from external port 8081 to internal
8080 the ProtocolMetaData is of. This effects the ServletProtocol
which is attempting to use this information to communicate with
the in-container test case as well as URL injection on the client
side via @ArquillianResource.
When the ProtocolMetaData is created, the object is intercepted
bu Cube to update the data based on the port we know are being
forwarded.
fixes #12