Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShiftAssistant : add a scale method with applicationName #1054

Closed
wants to merge 3 commits into from
Closed

Conversation

dcdh
Copy link
Contributor

@dcdh dcdh commented May 18, 2018

Short description of what this resolves:

I have got a Wildfly Swarm application using jaxrs, and JPA. My application is linked with a PostgreSQL database.

I want to test my application when the database is down (scale defined to 0) to ensure that my rest api will respond as expected (custom json response with custom response code).

However, using OpenShiftAssistant, is not currently possible because the scale method used the last deployed application name.

To run my application I need to run PostgreSQL first and then my Wildfly application to avoid it to crash on startup.

Changes proposed in this pull request:

On this pull request I have added a scale method with applicationName and desired scale parameters on both OpenShiftAssistant and KubernetesAssistant.

I have mutualized some methods like awaitApplicationReadinessOrFail.

Regards,
Damien

Fixes #1052

@dcdh
Copy link
Contributor Author

dcdh commented May 18, 2018

About the conflict on KubernetesAssistant
in awaitApplicationReadinessOrFail(final String applicationName) it must be .withName(applicationName).isReady(); because applicationName referds to the method variable and not the class variable.

@lordofthejars
Copy link
Member

Thank you so much, LGTM!! Can you resolve the conflict? Then when I get a green from Travis I will merge.

@lordofthejars lordofthejars self-requested a review May 18, 2018 13:57
Copy link
Member

@lordofthejars lordofthejars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just resolve the merge conflicts and then I will merge. Thanks :)

@dcdh
Copy link
Contributor Author

dcdh commented May 19, 2018

Thanks for accepting this PR. Will you plan a new release soon ?

@lordofthejars
Copy link
Member

ASAP we merge it, we can do it.

@dipak-pawar
Copy link
Contributor

Closing this as opened #1056

@dipak-pawar dipak-pawar closed this Jun 8, 2018
@dipak-pawar
Copy link
Contributor

Thank you @dcdh for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenShiftAssistant : add a scale method with applicationName
3 participants