ComponentsContainer is not more generic

[jhuska]

It was my mistake to declare ComponentsContainer as generic, since it can not have only one generic type. ITs method getContent() is generic and it is enough.

[buildhive]

An Innovative Testing Platform for the JVM » arquillian-graphene #52 SUCCESS
This pull request looks good
(what's this?)

[lfryc]

Hey Juraj, it's not clear for me: ComponentsContainer says it contains other components.

By my opinion it should say it could return another fragment - either a component or composition of several components.

But I don't think it should return list of components, because as you probably wanted to say, we know nothing about the type of list members.

So what about having ComponentContainer<T> with method <T> getContent() method?

Then you could use it as:

@FindBy PopupComponent<RegistrationForm> registrationPopup;

or

@FindBy PopupComponent<ButtonComponent> warningPopup;

[jhuska]

Hey Lukas,

I used that approach because I had wanted ComponentContainer which can hold more than one Page Fragment.

For example PopupComponent would return List<NestedElements<?>>, with for example NestedElements<RegistrationForm>, NestedElements<Calendar>, NestedElements<CommandButton> items.

However, I found out that this approach is not type safe :(

I will rework it to your proposition and when someone would need ComponentContainer which will hold more PageFragments, he will just implement ComponentConainer<T, E, ...>.

[buildhive]

An Innovative Testing Platform for the JVM » arquillian-graphene #61 SUCCESS
This pull request looks good
(what's this?)

[lfryc]

Juraj, is there already test covering PageFragmentsContainer usage?

[lfryc]

Btw commits contain some old stuff, could you please rebase on master?

Ideally you should create issue + squash commits just to one.

[jhuska]

I have replaced this pull request with
#72

It was easier for me to do so.

Closing therefore.