ARQGRA-199: Provide a way to create Page Fragments dynamically #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An Innovative Testing Platform for the JVM » arquillian-graphene #137 FAILURE |
|
An Innovative Testing Platform for the JVM » arquillian-graphene #138 SUCCESS |
|
It did pass firstly because I did not commit new files in components API model. |
* To enable this PageFragmentEnricher#createPageFragment and related methods were made static. * Test which creates PageFragment from TabPanel dynamically added. * Static Arquillian#createPageFragment added
|
An Innovative Testing Platform for the JVM » arquillian-graphene #144 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable this
PageFragmentEnricher#createPageFragmentand relatedmethods were made static. Test which creates PageFragment from TabPanel
dynamically added.
Question: Do you have any concern about making
PageFragmentEnricher#createPageFragmentaspublic static? Me not. But another approach can be to create something like Factory class ...