Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code #7

Closed
vicsufer opened this issue Feb 2, 2018 · 2 comments
Closed

Refactor code #7

vicsufer opened this issue Feb 2, 2018 · 2 comments
Assignees
@thewillyhuman @CarlosGarciaHdez
Labels
affects: code difficulty: easy-one status: accepted type: proposal
Milestone
first-deliverable

Comments

@vicsufer
Copy link
Member

vicsufer commented Feb 2, 2018

The new requirements does not longer has users only as actor of the system, therefore I believe the classes should be ranamed.
Also the new specification for the master CVS is different. Therefore at the moment we have useless attributes (Birth, nationality, ... ) on our User class so we should clean them from the sourcecode.

Proposal:

  • Rename "User" to "Agent"
  • Rename "UserInfo" to "AgentInfo"
  • Rename "UserInfoAdapter" to "AgentInfoAdapter"
  • Remove dateOfBirth, nationality and address from "User"(Agent) class
@thewillyhuman thewillyhuman self-assigned this Feb 2, 2018
@thewillyhuman thewillyhuman added this to the first-deliverable milestone Feb 2, 2018
@thewillyhuman
Copy link
Contributor

Nice, no problem on that.

@CarlosGarciaHdez
Copy link
Contributor

Refactoring done. Also changed UserLoginInfo to AgentLoginInfo

CarlosGarciaHdez added a commit that referenced this issue Feb 3, 2018
@CarlosGarciaHdez
Refactor code issue #7
8cd7dc4
CarlosGarciaHdez added a commit that referenced this issue Feb 3, 2018
@CarlosGarciaHdez
Merge pull request #22 from Arquisoft/refactor
ea2c50d 
Refactor code issue #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thewillyhuman thewillyhuman

@CarlosGarciaHdez CarlosGarciaHdez

Labels
affects: code difficulty: easy-one status: accepted type: proposal
Projects
None yet
Milestone
first-deliverable
Development

No branches or pull requests
3 participants
@thewillyhuman @vicsufer @CarlosGarciaHdez