Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Torque units in diesel generator is incorrect #1300

Closed
dchassin opened this issue Jun 26, 2023 · 0 comments · Fixed by #1301
Closed

Torque units in diesel generator is incorrect #1300

dchassin opened this issue Jun 26, 2023 · 0 comments · Fixed by #1301
Assignees
Labels
bug Request a fix or change to the code

Comments

@dchassin
Copy link
Member

Problem description

Generator torque property is incorrect.

Steps to reproduce

Run the command gridlabd --modhelp generators:diesel_dg | grep torque and inspect the output. The unit of torque is N.

Expected behavior

The correct unit of torque is N.m.

System information

  • GridLAB-D version: HiPAS GridLAB-D 4.3.2-230609 (develop) Darwin
  • Operating system: Darwin MacBook-Pro-2.local 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 21:00:17 PST 2023; root:xnu-8796.101.5~3/RELEASE_X86_64 x86_64

Supporting information

Note that https://github.com/gridlab-d/gridlab-d/blob/master/generators/diesel_dg.cpp does not use the torque property anymore.

@dchassin dchassin added the bug Request a fix or change to the code label Jun 26, 2023
@dchassin dchassin self-assigned this Jun 26, 2023
dchassin added a commit that referenced this issue Jun 26, 2023
@dchassin dchassin linked a pull request Jun 26, 2023 that will close this issue
dchassin added a commit that referenced this issue Jun 26, 2023
* Fix issue #1300
* Fix units
@dchassin dchassin closed this as completed Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Request a fix or change to the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant