Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Develop fix save conversion #780

Merged
merged 5 commits into from
Oct 26, 2020
Merged

Develop fix save conversion #780

merged 5 commits into from
Oct 26, 2020

Conversation

dchassin
Copy link
Member

This PR fixes an error in how file conversion is performed when saving to non-standard formats.

Current issues

None

Code changes

  • Fix GldMain:subcommand()
  • Fix gldcore/saveall()

Documentation changes

None

Test and Validation Notes

None

@dchassin dchassin added the bug Request a fix or change to the code label Oct 14, 2020
@dchassin dchassin added this to To do in HIPAS via automation Oct 14, 2020
HIPAS automation moved this from To do to Review pending Oct 23, 2020
Copy link
Collaborator

@aivanova5 aivanova5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac validation fails on

ERROR    [INIT] : /Users/alyona_slac/gridlabd/slacgismo_gridlabd/market/autotest/test_dutycycle_CPP.glm error unexpected, code 5 (simulation failed) in 0.7 seconds

with error:

ERROR    [2000-01-01 23:30:00 PST] : 2000-01-01 23:30:00 PST: object ZIPload:29 stopped its clock (exec)!
ERROR    [2000-01-01 23:30:00 PST] : exec halted: synchronization failed
FATAL    [2000-01-01 23:30:00 PST] : shutdown after simulation stopped prematurely
FATAL    [2000-01-01 23:30:00 PST] : environment startup failed: No such file or directory

Error made it into develop branch and supersedes this PR. See PR #787

HIPAS automation moved this from Review pending to Merge pending Oct 23, 2020
This reverts commit 4376e34.
Reverting problematic PR
@aivanova5 aivanova5 merged commit 6da4443 into develop Oct 26, 2020
HIPAS automation moved this from Merge pending to Done Oct 26, 2020
@aivanova5 aivanova5 deleted the develop-fix-save-conversion branch October 26, 2020 21:10
@aivanova5 aivanova5 mentioned this pull request Oct 26, 2020
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Request a fix or change to the code
Projects
No open projects
HIPAS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants