Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forge FTBFS with libglm-dev 0.9.9~a2-1 #160

Closed
ghisvail opened this issue Feb 2, 2018 · 5 comments · Fixed by #161
Closed

forge FTBFS with libglm-dev 0.9.9~a2-1 #160

ghisvail opened this issue Feb 2, 2018 · 5 comments · Fixed by #161

Comments

@ghisvail
Copy link
Contributor

ghisvail commented Feb 2, 2018

Forwarded from Debian-Bug#888931.

The issue is with a recently introduced macro blocking experimental features of the API. It should be just a matter of defining GLM_ENABLE_EXPERIMENTAL or ensuring you are not using this code path.
@9prady9
Copy link
Member

9prady9 commented Feb 2, 2018

@ghisvail We don't use quaternion math per say. But if whatever is being used internally uses this GLM_GTX_dual_quaternion, we need to refactor that portion. Thank you for reporting it. Any suggestions on the fix are also appreciated. thank you

@9prady9
Copy link
Member

9prady9 commented Feb 2, 2018

Looks like defining GLM_ENABLE_EXPERIMENTAL is the easy way out. But that would require a fix again in future when this is removed.

@9prady9 9prady9 mentioned this issue Feb 5, 2018
Merged
@9prady9
Copy link
Member

9prady9 commented Feb 5, 2018

@ghisvail I have removed the header that caused the issue in PR #161 . Can you please test this change and let me know if it fixed the problem. Thank you.

@9prady9
Copy link
Member

9prady9 commented Mar 13, 2018

@ghisvail Can you please confirm if the PR fixed the problem on debian.

@9prady9
Copy link
Member

9prady9 commented Apr 6, 2018

I have merged the PR. Please reopen the issue if it is still an issue on Debian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove unused glm header inclusion 9prady9/forge
2 participants
@ghisvail @9prady9