Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] SIGINT and SIGTERM Fix #6

Closed
Arraying opened this issue Aug 3, 2022 · 3 comments
Closed

[Dashboard] SIGINT and SIGTERM Fix #6

Arraying opened this issue Aug 3, 2022 · 3 comments
Assignees
@Arraying
Labels
bug Something isn't working
Milestone
MVP

Comments

@Arraying
Copy link
Owner

Arraying commented Aug 3, 2022

Currently ^C does not terminate the process. This is probably because both Express and the CLI are listening and need to support proper exit handlers.
@Arraying Arraying added the bug Something isn't working label Aug 3, 2022
@Arraying Arraying added this to the MVP milestone Aug 3, 2022
@Arraying Arraying self-assigned this Aug 3, 2022
@Arraying
Copy link
Owner Author

Implemented in ee1e687.

@Arraying
Copy link
Owner Author

This does not handle SIGTERM which is used by Docker desktop.

@Arraying Arraying reopened this Nov 18, 2022
@Arraying Arraying changed the title [Dashboard] SIGINT Fix [Dashboard] SIGINT and SIGTERM Fix Nov 18, 2022
@Arraying
Copy link
Owner Author

Implemented in d54501c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arraying Arraying

Labels
bug Something isn't working
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@Arraying