Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonadError instance for Option #238

Closed
pakoito opened this issue Aug 28, 2017 · 4 comments
Closed

MonadError instance for Option #238

pakoito opened this issue Aug 28, 2017 · 4 comments
Labels
enhancement help wanted

Comments

@pakoito
Copy link
Member

pakoito commented Aug 28, 2017 •
edited
Loading

We need a MonadError instance for Option. You can base the implementation in Either's: https://github.com/kategory/kategory/blob/master/kategory/src/main/kotlin/kategory/instances/EitherInstances.kt#L31-L39 except Either.Left(exception) becomes Option.None
@victorg1991
Copy link
Contributor

victorg1991 commented Aug 28, 2017 •
edited
Loading

Me lo pido :D @pakoito

@pakoito
Copy link
Member Author

pakoito commented Aug 28, 2017

It's there, just the monadError() call in the companion is missing.

@pt2121
Copy link
Contributor

pt2121 commented Sep 9, 2017

anyone working on this? can i take it?

@pakoito
Copy link
Member Author

pakoito commented Sep 9, 2017 •
edited
Loading

It's actually just a single call missing from the companion, and @raulraja is working on a new solution that will deprecate it. Better close this ticket to avoid confusion :D

@pakoito pakoito closed this as completed Sep 9, 2017
@wiyarmir wiyarmir mentioned this issue Sep 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pakoito @pt2121 @victorg1991