Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Jobs #234

Merged
merged 16 commits into from
Aug 29, 2017
Merged

Improve Jobs #234

merged 16 commits into from
Aug 29, 2017

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Aug 26, 2017

After reading through the Coroutines documentation (https://github.com/Kotlin/kotlinx.coroutines/blob/master/coroutines-guide.md#coroutine-basics) I realised there were a couple of mistakes on our JobW implementation. I've corrected them.

This PR adds more constructors for JobW, fixes Jobs being run twice, and makes the API a bit cleaner. It also fixes MonadErrorLaws to take separate equals for errors and successes.

@pakoito pakoito requested review from raulraja and a team August 26, 2017 13:54
@codecov-io
Copy link

codecov-io commented Aug 26, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@f2fe59d). Click here to learn what that means.
The diff coverage is 47.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #234   +/-   ##
=========================================
  Coverage          ?   49.25%           
  Complexity        ?      231           
=========================================
  Files             ?      108           
  Lines             ?     2410           
  Branches          ?      285           
=========================================
  Hits              ?     1187           
  Misses            ?     1113           
  Partials          ?      110
Impacted Files Coverage Δ Complexity Δ
...ain/kotlin/kategory/effects/data/internal/Utils.kt 79.16% <ø> (ø) 0 <0> (?)
...st/src/main/kotlin/kategory/laws/MonadErrorLaws.kt 9.09% <0%> (ø) 1 <0> (?)
...ts-test/src/main/kotlin/kategory/laws/AsyncLaws.kt 2.08% <0%> (ø) 1 <0> (?)
...cts/src/main/kotlin/kategory/effects/data/JobKW.kt 43.39% <43.39%> (ø) 3 <3> (?)
...ffects/src/main/kotlin/kategory/effects/data/IO.kt 72.44% <83.33%> (ø) 10 <0> (?)
...otlin/kategory/effects/instances/JobKWInstances.kt 85.71% <85.71%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2fe59d...a399f56. Read the comment docs.

This was referenced Aug 26, 2017
@pakoito pakoito merged commit 8e35d6d into master Aug 29, 2017
@pakoito pakoito deleted the paco-betterjobs branch August 29, 2017 10:36
@wiyarmir wiyarmir mentioned this pull request Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants