Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplicativeError laws #236

Merged
merged 6 commits into from
Sep 2, 2017
Merged

Add ApplicativeError laws #236

merged 6 commits into from
Sep 2, 2017

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Aug 26, 2017

This PR adds the laws for ApplicativeError. They add another EQ to the call chain, it wasn't too painful. Depends on #234, see diff in #235

@pakoito pakoito requested review from raulraja, JorgeCastilloPrz and a team August 26, 2017 16:51
@codecov-io
Copy link

codecov-io commented Aug 26, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b072521). Click here to learn what that means.
The diff coverage is 6.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage          ?   49.57%           
  Complexity        ?      232           
=========================================
  Files             ?      109           
  Lines             ?     2453           
  Branches          ?      287           
=========================================
  Hits              ?     1216           
  Misses            ?     1124           
  Partials          ?      113
Impacted Files Coverage Δ Complexity Δ
...st/src/main/kotlin/kategory/laws/MonadErrorLaws.kt 9.09% <0%> (ø) 1 <0> (?)
...ts-test/src/main/kotlin/kategory/laws/AsyncLaws.kt 2.08% <0%> (ø) 1 <0> (?)
kategory/src/main/kotlin/kategory/data/Option.kt 60.41% <100%> (ø) 7 <0> (?)
.../main/kotlin/kategory/laws/ApplicativeErrorLaws.kt 3.22% <3.22%> (ø) 1 <1> (?)
.../src/main/kotlin/kategory/generators/Generators.kt 51.28% <7.69%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b072521...0a4a969. Read the comment docs.

@JorgeCastilloPrz
Copy link
Member

Can this be merged now ?

@pakoito
Copy link
Member Author

pakoito commented Sep 2, 2017

I need to fix the conflicts first. Haven't had the time yet.

pakoito added 2 commits September 2, 2017 18:13
# Conflicts:
#	kategory-effects/src/test/kotlin/kategory/effects/data/JobKWTest.kt
@pakoito pakoito merged commit 3160501 into master Sep 2, 2017
@pakoito pakoito deleted the paco-aperrorlaws branch September 2, 2017 17:20
@wiyarmir wiyarmir mentioned this pull request Sep 15, 2017
rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants