Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplicativeError laws #235

Closed
wants to merge 3 commits into from
Closed

Conversation

pakoito
Copy link
Member

@pakoito pakoito commented Aug 26, 2017

This PR adds the laws for ApplicativeError. They add another EQ to the call chain, it wasn't too painful. Depends on #234

@pakoito
Copy link
Member Author

pakoito commented Aug 26, 2017

Wrong branch to merge to

@pakoito pakoito closed this Aug 26, 2017
@codecov-io
Copy link

Codecov Report

Merging #235 into paco-betterjobs will increase coverage by 0.32%.
The diff coverage is 6.38%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             paco-betterjobs     #235      +/-   ##
=====================================================
+ Coverage              49.01%   49.34%   +0.32%     
- Complexity               231      232       +1     
=====================================================
  Files                    103      104       +1     
  Lines                   2395     2438      +43     
  Branches                 285      287       +2     
=====================================================
+ Hits                    1174     1203      +29     
- Misses                  1111     1122      +11     
- Partials                 110      113       +3
Impacted Files Coverage Δ Complexity Δ
...st/src/main/kotlin/kategory/laws/MonadErrorLaws.kt 9.09% <0%> (ø) 1 <0> (ø) ⬇️
...ts-test/src/main/kotlin/kategory/laws/AsyncLaws.kt 2.08% <0%> (ø) 1 <0> (ø) ⬇️
kategory/src/main/kotlin/kategory/data/Option.kt 60.41% <100%> (+2.08%) 7 <0> (ø) ⬇️
.../main/kotlin/kategory/laws/ApplicativeErrorLaws.kt 3.22% <3.22%> (ø) 1 <1> (?)
.../src/main/kotlin/kategory/generators/Generators.kt 51.28% <7.69%> (-22.8%) 0 <0> (ø)
...ffects/src/main/kotlin/kategory/effects/data/IO.kt 73.46% <0%> (+1.02%) 10% <0%> (ø) ⬇️
...ects/src/main/kotlin/kategory/effects/data/JobW.kt 50.94% <0%> (+7.54%) 3% <0%> (ø) ⬇️
...n/kotlin/kategory/effects/instances/IOInstances.kt 69.23% <0%> (+7.69%) 0% <0%> (ø) ⬇️
.../main/kotlin/kategory/instances/OptionInstances.kt 66.66% <0%> (+11.11%) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175d7f5...7888ede. Read the comment docs.

rachelcarmena pushed a commit that referenced this pull request Feb 24, 2021
* Remove suspend from tryOffer

* Add unsafe constructors for Queue

* Queue - refactor offer1 to tryOffer1

* Remove first in last out strategy from Queue

Co-authored-by: danieh <daniel.montoya@47deg.com>
Co-authored-by: Alberto Ballano <aballano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants