Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd Output - Portuguese #3

Closed
joumorisu opened this issue Mar 11, 2020 · 3 comments · Fixed by #41
Closed

Odd Output - Portuguese #3

joumorisu opened this issue Mar 11, 2020 · 3 comments · Fixed by #41
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@joumorisu
Copy link

joumorisu commented Mar 11, 2020

Describe the bug
The "1p" of "Indicativo pretérito perfeito simples" always produces odd output with -AR verbs. For example, with the word "pegar", it outputs "peg)". Same thing with "falar" or any other -AR verb. Alternatively, the word might produce a null. "trabalhar" produces null in the same spot ("1p" of "Indicativo pretérito perfeito simples"). This bug only affects -AR verbs (-ER and -IR output seems normal). I tested 837 -AR verbs, and every single one of them displayed this issue.

The same behavior occurs in both custom code (i.e., when mlconjug is imported) and when using the command line tool.

To Reproduce

  1. Run mlconjug pegar -l pt
  2. Run mlconjug trabalhar -l pt
  3. Run mlconjug comer -l pt
  4. Run mlconjug partir -l pt

Expected behavior
Pegar --> 1p, Indicativo pretérito perfeito simples = pegamos
Trabalhar --> trabalhamos
Comer --> comemos
Partir --> partimos

@SekouDiaoNlp
Copy link
Collaborator

Hi @Jmorr10 , thanks for using mlconjug3 and for filing this bug report.

I will investigate this issue and release a new version with the fix as soon as possible.

Cheers,

SekouDiaoNlp.

@SekouDiaoNlp SekouDiaoNlp self-assigned this Mar 12, 2020
@SekouDiaoNlp SekouDiaoNlp added bug Something isn't working good first issue Good for newcomers labels Mar 12, 2020
@SekouDiaoNlp
Copy link
Collaborator

Hi @Jmorr10 !

I am finally out of lockdown and started looking into your issue.

I am in the process of fixing it and should push a fix tomorrow here on github and will release version 3.7.2 with the fix on PyPi tomorrow.

Sorry for the delay.

I will add a comment to this issue as soon as I upload the new version to PyPi to let you know.

Cheers,

SekouDiaoNlp.

@SekouDiaoNlp
Copy link
Collaborator

SekouDiaoNlp commented Apr 30, 2020

Hi @Jmorr10 !

I just released version 3.7.3 of mlconjug3 on PyPi.

This version fixes the issue with the portuguese verbs.

Now, running mlconjug3 pegar -l pt or mlconjug3 trabalhar -l pt gives the expected results for "1p" of "Indicativo pretérito perfeito simples".

Can you check the new version and let me know if it solves the issue for you?

Thanks in advance.

SekouDiaoNlp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants