Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please warn that this project requires tdlib < 1.6.5 #120

Closed
3ynm opened this issue Sep 24, 2021 · 7 comments
Closed

please warn that this project requires tdlib < 1.6.5 #120

3ynm opened this issue Sep 24, 2021 · 7 comments

Comments

@3ynm
Copy link

3ynm commented Sep 24, 2021

It took me one day to compile tdlib on a SBC only to discover that the version I compiled is incompatible with this project.

@BenWiederhake
Copy link
Contributor

Where would you put this warning? It's already there in CMakeLists.txt. If you find a good place, just make a PR.

@c0dev0id
Copy link

I'm currently looking into packaging tdlib-purple for OpenBSD. We have tdlib 1.7.7 already, which is required for the telegram cli client "tg". Now, before I start bundling tdlib 1.6.5 into the tdlib-purple port, I want to ask if tdlib-purple wants to support newer tdlibs in mid-term (aka someone is working on it) or if it's going to be stuck on 1.6.5 for the foreseeable future.

@BenWiederhake
Copy link
Contributor

Want: Yes
someone is working on it: No
going to be stuck on 1.6.5 for the foreseeable future: Yes, probably … unless I can convince you to port it? :D

This might be a helpful starting point: #98
In particular, I hope it's really only a silly issue regarding either chat names, or some kind of ID that I misunderstood. The bug is probably in the diff, even, but I'm just too stupid.

@c0dev0id
Copy link

c0dev0id commented Nov 26, 2021

Hi Ben, thanks for the prompt response. This looks like more than wiping out a few incompatibilities. Thanks for the pointer to the diff.

EDIT: After reading tdlib/td#1718 (comment) it is clear to me that having tdlib around as independent library is not going to work anyway..

@ars3niy
Copy link
Owner

ars3niy commented Nov 26, 2021

The thing with tdlib is that even minor versions can be incompatible in major ways. It's not really meant to be a system-wide shared library.

@mckaygerhard
Copy link

guys now take in consideration telegramdesktop/tdesktop#17330 telegram changes api now.. RPCError 406: UPDATE_APP_TO_LOGIN (caused by SignInRequest)

@ars3niy
Copy link
Owner

ars3niy commented Dec 7, 2021

Now tdlib version requirement is >= 1.7.8 (no upper bound yet but there will be one as soon as tdlib changes something again). I suggest putting this in readme #126

@ars3niy ars3niy closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants