-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When I click to open "sidr side menu" I´m also clicking on my sidr menu item #165
Comments
Add this line after line 304 which is the e.preventDefault(); inside the only click event. e.stopPropagation(); // add this |
We're having the same issue. Unfortunately, this "fix" doesn't work. |
Same here. Hopefully someone finds a fix for this soon. |
I came accross this and found out that this happanes on smartphones. Not tablets. What you could do right now is to:
|
Same problem here! I'd like to position the menu button and the menu on the right side, but when sidr opens, it always selects the first or second menu item depending on the touch position! |
this issue has been discussed but arbery stays silent |
I used these plugin and everything is good now and problem solved with me |
You can check my solution of this problem right here : |
hmm, this still does not work on my websites. see www.konkreet.ch
could it be, that there is no "click" event fired, but a "touch", "touchend" or something? I don't have an android device to test... |
How it doesn't work when you have no android to test on ? |
i tested on a device of a friend... ;) sorry! |
Does it go into the on click callback function? Try debugging it. Check if you are binding this to the right elements. Make sure you change your plugin code. |
Thank you remon. FastClick fixed the problem for me, too. |
…ixes #179 and fixes #266 and fixes #246 and fixes #245 and fixes #211 and fixes #178 and fixes #118 and fixes #98 and fixes #214 and fixes #117 and fixes #130 and fixes #144 and fixes #146 and fixes #165 and fixes #189 and fixes #193 and fixes #203 and fixes #213 and fixes #218 and fixes #240 and fixes #249
Preparing a new version with a fix for this https://github.com/artberri/sidr/tree/reborn |
I followed the sidr documentation here: http://www.berriart.com/sidr/.
And I already have my sidr side left menu working fine.
But on my mobile,only on android default browser, when I click in my link "Open Menu" I also click on my menu item "Menu 1", and so it opens my submenu items with my toggle effect. And I dont want this.
I just want to open my submenu items when I click in my Menu items, and not in my link to open the menu.
I found a solution, that is, if I put my sidr menu with some margin top, to not align with my link to open the menu, the problem is solved, like in my second image.
But I dont want to give that margin-top, so Im trying look for other solution.
Somebody there have exprience with this plugin and can give me a help??
If my link to open the sidr menu is aligned with my menu Item, Im clicking on both when I click to open the menu!
If my link to open the menu is not aligned with menu 1... I only click on my link and it works fine!
This is my jQuery to start sidr plugin:
The text was updated successfully, but these errors were encountered: