Sidr doesn't work on some computers/browser

[ianharris32]

Really strange one.. I have people use a site I have used sidr on and the menu doesn't slide out. Thing is, on every computer I have tried it works, until today I experienced it not working. This was on google chrome as well.
Since then I have changed the order of my js and css in the head tags to call the js first. Not sure if that solves it. Maybe I am missing something in the code... but I can't understand why it doesn't work on some computers, even with the same browser.

the site is... thelangton.org.uk

Would appreciate the help asap please, I want to get this site finished.

Cheers

[englishextra]

works in chrome and ie10 on win7 x64
I suggest you move all js to the bottom of the page because sidr shoud see the navigation list that it has to hide first also you might want to hide sidr menu in your css to avoid flashing content
but as you have placed js in blocking manner at the top it works even in your case
let's wait what the developer says and details from your users what effect they actually encounter
btw - nice design

[ianharris32]

Thanks for this. What do you mean by hiding the css?

I have worked this morning on a computer where it is not working in chrome. It seems that the sidr div doesn't get assigned the inline css by the script. So on a computer where it works fine it says:

on those computers where it is not working it says just:

So it is not effecting the element at all. The computer runs the latest version of chrome also so thats not the case.

Thanks for help on this.

[englishextra]

Why dont you give details of the os on that computer where chrome wont produce what you need

[ianharris32]

windows 7, sp1, 64 bit
Cheers

[englishextra]

it works on win7 sp1 x64 in chrome 33.0.1750.154 and 35.0.1909.3 canary

can't help you then - please address @artberri

I'm just watching this repo because I widely use sidr in my projects

[xinz]

Hello,

I'm new to here, I also occur this issue (FF 30, Mac OS 10.9) refer the Simplest Usage of the document, the click function won't work, I submit a pull request #179, hope it can be helpfull.

Thanks,
Xin

[englishextra]

@ianharris32 @xinz @artberri It appears that I used an older version here
http://cdn.jsdelivr.net/jquery.sidr/1.1.1/jquery.sidr.js

and you use a new one with changes at the bottom
http://www.thelangton.org.uk/wp-content/themes/langtontheme/js/jquery.sidr.js
it's identical to here
https://github.com/artberri/sidr/blob/master/dist/jquery.sidr.js

Compare the very bottom code in those two and the old one from jsdelivr cdn above

[xinz]

@englishextra , yes, I occur this issue using the latest source (should be 1.2.1), the older version 1.1.1 won't occur this click issue in the non touch screen.

[englishextra]

@xinz yeah-yeah

[xinz]

@englishextra :)

[ianharris32]

Hi @xinz

I'm new to github, so getting a feel for it. I notice on the pull request you added some changes to the code.. Would that help my issue if I add that in?

[xinz]

Hi @ianharris32

I'm not quite sure about it for you, but I think we occur a similar issue and that changes fix my issue, you can try it and welcome feedback.

[ianharris32]

Hey @xinz , @artberri

This hasn't solved it. It turns out the issue is with Google Chrome, but I can't explain it at present. I have had two laptops side by side, both with the most recent up to date version of chrome. On one it works, on one it doesn't. There must be something that chrome has activated that is stopping it from working.

Any more thoughts?

Thanks for your help

[ianharris32]

Could it be a conflict between some of my javascript/jquery? possibly classie.js?

[xinz]

Hi @ianharris32,

I can reproduce your site's issue in FF30.

Refer your site's including sidr code http://www.thelangton.org.uk/wp-content/themes/langtontheme/js/jquery.sidr.js, after you add my changes #179, but there is a deleted line 288 should not be added, could you remove the line """if('ontouchstart' in document.documentElement) {""" and try again?

Good luck!

[ianharris32]

ok i have deleted that line of code. Do you have a browser to test in?
I keep contacting people who I know have an issue.

Cheers

[ianharris32]

hi @xinz

Have had some feedback from someone with the issue and they reported it fixed!!

Just checking on a few other users.
Thank you so much!!!

[xinz]

@ianharris32, glad to heard that, my pleasure :)

[artberri]

Preparing a new version with a fix for this https://github.com/artberri/sidr/tree/reborn