Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidr not opening on Google Chrome 36 #193

Closed
Webtransformer opened this issue Jul 29, 2014 · 6 comments
Closed

Sidr not opening on Google Chrome 36 #193

Webtransformer opened this issue Jul 29, 2014 · 6 comments

Comments

@Webtransformer
Copy link

Sidr is working well on IPAD2, Android, Firefox and even Internet Explorer 8 but in Google Chrome v36 the content seems to be missing.

Here is a temporary project Link. The left top button is the link button for sidr.
http://2016.webtransformer.de/leistungen.

I am using the latest sidr version.

@aorfevre
Copy link

aorfevre commented Aug 8, 2014

I'm expecting the same issue as Webtransformer.
Sidr is working perfectly on other explorer but is not displaying side bar on Chrome 36.

Even the div is not "hidden".
I do not have any warning nor error triggered to the console.

I'll try to investigate that issue and give a feedback if I found something.
Thank you for your return,

@aorfevre
Copy link

aorfevre commented Aug 8, 2014

This issue resides in the fact of detecting or not the ontouchstart event (if screen is touchable).

On my case, I'm working with a surface, that has a touchable screen.
Therefore, the plugin triggers the touch event;
After further tests, in fact, the slide is well displayed if I touch with my finger.

However, I'm not expecting this behaviour has I'm on a computer.

I recommand to add a test on the the computer to add or not the ontouch event.
If it s a mobile, add. If not, add click event.

I'm thinking about adding http://detectmobilebrowsers.com/ solution

Do you hve any suggestion ?

@aorfevre
Copy link

aorfevre commented Aug 8, 2014

Soluton tested & validated.
I've never done any push request... so here is in short words what I did :

  • ADD A CHECK on Mobile :
    var mobileCheck = FUNCTION_OF_http://detectmobilebrowsers.com/
  • ADD THIS TEST
    if(mobileCheck && 'ontouchstart' in document.documentElement) {

@Webtransformer
Copy link
Author

Thanks, I will test it in my next project. Meanwhile I had to use another plugin.

@mabasic
Copy link

mabasic commented Nov 6, 2015

For the love of God! It took me a lot of time to notice this.

If you have a touch screen clicking with the mouse on the toggle will not open the menu, but using your finger on it will open it.

artberri added a commit that referenced this issue Jan 9, 2016
…ixes #179 and fixes #266 and fixes #246 and fixes #245 and fixes #211 and fixes #178 and fixes #118 and fixes #98  and fixes #214 and fixes #117 and fixes #130 and fixes #144 and fixes #146 and fixes #165 and fixes #189 and fixes #193 and fixes #203 and fixes #213 and fixes #218 and fixes #240 and fixes #249
@artberri
Copy link
Owner

artberri commented Jan 9, 2016

Preparing a new version with a fix for this https://github.com/artberri/sidr/tree/reborn

@artberri artberri closed this as completed Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants