Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gunicorn: use async workers #97

Closed
sevein opened this issue Nov 30, 2016 · 1 comment
Closed

gunicorn: use async workers #97

sevein opened this issue Nov 30, 2016 · 1 comment

Comments

@sevein
Copy link
Member

sevein commented Nov 30, 2016

In worker_class, use any of the following options: eventlet, gevent, tornado, gthread. Not considering asyncio because it's Py3 only.
I think it's preferably to use one of the first two options for various reasons. Between the two, I'm inclined to prefer eventlet because it does carry simpler dependencies (eventlet). Ultimately the user could decide which worker class to use.

The reasons for moving to async workers are obvious. One example that makes the underlying issue easier to understand: say you deploy SS with two workers. If one of the workers is busy serving a file to the user, you just compromised 50% of the availability of the server. If the case was that you deployed the application with a single worker, the application will become unavailable to the rest of users. In general, our applications (dashboard and ss) should be able to make use of these worker classes with no changes but some testing is recommended.

@sevein
Copy link
Member Author

sevein commented Aug 8, 2017

Done in #123, using gevent.

@sevein sevein closed this as completed Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant