Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: culture fallback not working as expected in search/browse results when default culture not English #1602

Open
fiver-watson opened this issue May 24, 2023 · 0 comments
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.

Comments

@fiver-watson
Copy link
Contributor

Current Behavior

First reported in the user forum, 2023-05-24: https://groups.google.com/g/ica-atom-users/c/sPkgM1Wagu0/m/tKi82X13AAAJ

The user there claims this is a regression that worked as expected in their 2.6 installation before upgrading to 2.7 recently.

Reproduced locally in the AtoM Vagrant box (2.7.0.0.3), using the most recent update to stable/2.7.x.

Steps to reproduce the behavior

  1. With your default installation culture set to English, log in
  2. Create 2 new descriptions, with new creators:
    • For the first, flip the user interface to Spanish
    • For the second, flip back to English
  3. From the command-line, access apps/qubit/config/settings.yml
  4. Change the default_culture value to es and save
  5. Clear the application cache, restart PHP-FPM, and re-populate the search index
  6. Log in and navigate to Browse > Archival Descriptions

Error encountered

When the default installation culture is set to es:

  • With the UI language set to Spanish, The English-created description's creator does not display:

spanish-ui-english-description

  • With the UI language set to English, the Spanish-created description's creator does not display:

english-ui-spanish-description

Expected Behavior

Regardless of the culture the descriptions are created in or the language of the user interface, culture fallback should ensure that if there is no appropriate name/title in the current display culture, then the record will "fall back" and display the original name/title.

Meaning, in both English and Spanish UI settings (changed via the language menu), both creators should have names displayed in the related archival description stub result shown in Browse > Archival descriptions.

Possible Solution

Check for regressions introduced when revising the templates for 2.7.

Context and Notes

The original report in the user forum includes further screenshots. These show the standard BS2 theme. I also only tested locally using the default BS2 Dominion theme. When checking and performing QA, be sure to check both BS2 and BS5 template behavior.

Version used

AtoM 2.7 - stable/2.7.x in AtoM vagrant box version 2.7.0.3

Operating System and version

Ubuntu 20.04

Default installation culture

en / es for testing

PHP version

PHP 7.4

Contact details

No response

@fiver-watson fiver-watson added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

No branches or pull requests

1 participant