Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with mj-column, background-color #270

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Conversation

GoodPHP
Copy link
Contributor

@GoodPHP GoodPHP commented Dec 3, 2021

Issue with background-color in component mj-column

If add to canvas next code:

<mjml>
  <mj-head>
	<mj-title>test
	</mj-title>
  </mj-head>
  <mj-body background-color="#e5e5e5" width="729px">
	<!-- header -->
	<mj-section padding="36px 0 31px" background-color="#e7eee8">
	  <mj-column padding="0 15px" background-color="#350000" width="200px">
		<mj-text padding="0 0 30px" align="center" color="#fff" font-family="Raleway, sans-serif" font-size="24px" line-height="29px">
		  29.11.2021 19:00 MESZ
		</mj-text>
	  </mj-column>
	</mj-section>
  </mj-body>
</mjml>

and then if try to change background-color="#350000" to mj-column. Nothing was changed.

My fix copy background-color to style="" and it start works.

@ekkeguembel
Copy link

@DRoet this PR fixes an issue that came up in a Mautic project where GrapesJS is now the default editor and we expect to see more involvement and contribution going forward.
However, I am not familiar with this repo and the ways of doing things here (and I might ask Adrian but maybe starting some direct contact is better : )
Thus: Is there any good practice that helps getting PRs reviewed & merged quickly?

Thx :)

@DRoet
Copy link
Collaborator

DRoet commented Dec 22, 2021

Honestly I am not that involved with the project anymore, but I am still pretty active on GitHub and try to merge things ASAP.

Maybe you guys can claim a maintainer role from @artf but he can be pretty busy at times.

EDIT: this change is now released as v0.5.7, thanks for the PR!

@DRoet DRoet merged commit 5ac7b9c into GrapesJS:master Dec 22, 2021
@ekkeguembel
Copy link

Thanks @DRoet for merging and releasing - plus for kindly helping us getting on board!
I guess next time I'll touch base with @artf and over time we'll see where this involvement goes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants