Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move components into separate folders #38

Closed
johhnry opened this issue Oct 7, 2021 · 0 comments · Fixed by #43
Closed

Refactor: move components into separate folders #38

johhnry opened this issue Oct 7, 2021 · 0 comments · Fixed by #43
Labels
refactor Moving some code around

Comments

@johhnry
Copy link
Collaborator

johhnry commented Oct 7, 2021

Currently the components are in the components folder and some of them are alongside the pages folder.

It would be more appropriate to introduce another level of folder structure like common or wrappers
@johhnry johhnry added the refactor Moving some code around label Oct 7, 2021
johhnry added a commit that referenced this issue Oct 10, 2021
@johhnry
refactor: move components into folders closes #38
9cdd618
@johhnry johhnry linked a pull request Oct 10, 2021 that will close this issue
Various fixes #43
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Moving some code around
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various fixes ArtFXDev/silex-front
1 participant
@johhnry