Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout from 3.5.2 to 3.5.3 #2615

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2023

Bumps actions/checkout from 3.5.2 to 3.5.3.

Release notes

Sourced from actions/checkout's releases.

v3.5.3

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v3.5.3

Changelog

Sourced from actions/checkout's changelog.

v3.5.3

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the A-deps Area: Source and library dependencies. label Jul 1, 2023
@lopopolo
Copy link
Member

lopopolo commented Jul 2, 2023

Build is failed due to:

All of these dep PRs require upgrading proc-macro2 to at least 1.0.60.

lopopolo added a commit that referenced this pull request Jul 2, 2023
`proc-macro2` before 1.0.60 is incompatible with the latest nightly
since an unstable feature conditionally used by `proc-macro2` was
renamed.

This breakage had been triggering for a couple of weeks on the periodic
fuzzer builds. This build error additionally blocks the July 2023
dependabot dep update PRs. See:
#2615 (comment).

Fixed with a targeted `cargo update`:

```console
$ cargo update --package proc-macro2
    Updating crates.io index
    Updating proc-macro2 v1.0.59 -> v1.0.63
```

See:

- rust-lang/rust#113152
- dtolnay/proc-macro2#391

Error below:

```console
$ cargo +nightly check
   Compiling proc-macro2 v1.0.59
   Compiling jobserver v0.1.26
    Checking scolapasta-string-escape v0.3.0 (/Users/lopopolo/dev/artichoke/artichoke/scolapasta-string-escape)
    Checking getrandom v0.2.9
   Compiling nom v7.1.3
   Compiling clang-sys v1.6.1
    Checking errno v0.3.1
    Checking io-lifetimes v1.0.11
    Checking regex v1.8.3
    Checking tz-rs v0.6.14
    Checking nix v0.26.2
   Compiling artichoke v0.1.0-pre.0 (/Users/lopopolo/dev/artichoke/artichoke)
    Checking clap v4.3.1
error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /Users/lopopolo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.59/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

    Checking rustix v0.37.19
    Checking rand_core v0.6.4
    Checking spinoso-string v0.24.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-string)
    Checking spinoso-exception v0.1.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-exception)
    Checking spinoso-symbol v0.4.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-symbol)
    Checking spinoso-env v0.2.0 (/Users/lopopolo/dev/artichoke/artichoke/spinoso-env)
    Checking scolapasta-int-parse v0.2.2 (/Users/lopopolo/dev/artichoke/artichoke/scolapasta-int-parse)
   Compiling cc v1.0.79
For more information about this error, try `rustc --explain E0635`.
error: could not compile `proc-macro2` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
```
@lopopolo
Copy link
Member

lopopolo commented Jul 2, 2023

@dependabot rebase

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.5.2...v3.5.3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-3.5.3 branch from ca95db3 to 4e658e9 Compare July 2, 2023 04:41
@lopopolo lopopolo merged commit 0048fff into trunk Jul 2, 2023
20 checks passed
@lopopolo lopopolo deleted the dependabot/github_actions/actions/checkout-3.5.3 branch July 2, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: Source and library dependencies.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant