beforeRequest hook doesn't work

[andrevas]

Hi guys!
I noticed the next issue:
When trying to change my json before sending, defined beforeRequest function is not called. Adding afterResponse function working as expected. My code looks like that:

 {
  "config": {
    "target": "...my target...",
    "phases": [
      {"duration": 10, "arrivalRate": 5}
    ],
    "processor" : "helloJS.js",
    "defaults": {
      "headers": {
        "content-type": "application/json"
      }
    }
  },
  "scenarios": [
    {
      "flow": [
        {
          "post": {
            "url": "...my url...",
            "json": {
                 "my json"
            },
            "beforeRequest" : "foo"
          }
        }
      ]
    }
  ]
}

module.exports = {
    foo: foo
};

function foo (requestParams, context, ee, next) {
    console.log("TEST");
    return next();
}

[hassy]

Thanks @andrevas. Your code looks right and should be working, will need to investigate.

[danielo515]

Something similar is happening for me

In my case it only happens if I do the following

// file a.js
module.exports.funA = myfunction

// file b.js
module.exports.funB = myfunction

// file artillery.js
Object.assign( module.exports , require('./a.js'), require('./b.js'));

Then I configure those for the scenario:

config:
    target: 'https://localhost:3000'
    processor: "./artillery.js"
    tls:
        rejectUnauthorized: false
    phases:
        - duration: 10
          arrivalRate: 20
scenarios:
    - beforeRequest: ["funA","funB"]
      flow:
        - get:
            url: "/test"
            json: "{}"

Seems that the problem is that beforeRequest can not be an array. If I only include one function it works

[danielo515]

My issue is probably a problem on the YAML parser. Very early on the running phase the beforeRequest array is empty.
In function runScenario(script, intermediate, runState) the script specification already has an empty array for beforeRequest.

Regards

[danielo515]

Hello @hassy , finally I found the bug. It's pretty straighforward
The problem seems to be at line 82 of runner.js

 if (scenarioSpec.beforeRequest && !_.isArray(scenarioSpec.beforeRequest)) {
      scenarioSpec.beforeRequest = [scenarioSpec.beforeRequest];
    } else {
      scenarioSpec.beforeRequest = [];
    }

Why do you empty the array if it is an array? it makes no sense.

[hassy]

It needs to be set to an empty array if it's not defined (and left alone if it's an array). Easy fix. Thanks for investigating @danielo515!

[danielo515]

You're welcome @hassy

As a suggestion this worked fine for me:

if ( !_.isArray(scenarioSpec.beforeRequest)) {
      scenarioSpec.beforeRequest = scenarioSpec.beforeRequest ? [scenarioSpec.beforeRequest] : [];
    }

Regards