Fix/handle malformed cookiestring response #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanig1
commented
Jul 25, 2022
|
Is this a regression in v2.0.0-22, i.e. does it work with v2.0.0-21, or have we always had this issue? |
hassy
reviewed
Jul 27, 2022
core/lib/engine_http.js
Outdated
| try { | ||
| context._jar.setCookieSync(cookieString, url); | ||
| } catch (err) { | ||
| ee.emit('error', 'Could not parse cookieString from response header, skipping it ' + cookieString); |
There was a problem hiding this comment.
The messages from these error events go right into the metric report, so it's best to keep it short. How about something like cookie_parse_error_invalid_cookie?
For debugging we can log the current message with debug() instead.
There was a problem hiding this comment.
Done, used uppercase for the error message for consistency.
One detail is that we can get N error messages for one call (as there may be N invalid Set-Cookie headers)
hassy
reviewed
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment
tldr: handles malformed cookies received through a response Set-Cookie header
closes ART-574